Skip to content

⬆️ rust-analyzer #74290

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from

Conversation

matklad
Copy link
Member

@matklad matklad commented Jul 13, 2020

No description provided.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 13, 2020
@matklad
Copy link
Member Author

matklad commented Jul 13, 2020

@bors rollup=iffy

@matklad
Copy link
Member Author

matklad commented Jul 13, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 13, 2020

📌 Commit b78dd15 has been approved by matklad

@bors
Copy link
Collaborator

bors commented Jul 13, 2020

🌲 The tree is currently closed for pull requests below priority 20, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2020
@mati865
Copy link
Member

mati865 commented Jul 13, 2020

You should use r? @ghost in PR description if you do not expect review 😉

@matklad
Copy link
Member Author

matklad commented Jul 13, 2020

Good tip, fixed in rust-lang/rust-analyzer#5340

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 13, 2020
@Manishearth
Copy link
Member

@bors r-

#74303 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 13, 2020
@matklad
Copy link
Member Author

matklad commented Jul 13, 2020

Yup, legitimate failure, hopefully will be fixed next week. I am also going to add power check build to our CI — it’s the second time we fail with AtomicU64 error. I wish we had(transitive) portability lints

@matklad matklad closed this Jul 13, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants