Skip to content

Add and fix BTreeMap comments #74295

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Add and fix BTreeMap comments #74295

merged 1 commit into from
Jul 16, 2020

Conversation

ssomers
Copy link
Contributor

@ssomers ssomers commented Jul 13, 2020

No code changed (yet)

@rust-highfive
Copy link
Contributor

r? @hanna-kruppe

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 13, 2020
@hanna-kruppe
Copy link
Contributor

The whole BTree code is very out of cache for me (at least, the parts that I ever knew) and I'm a bit busy, so I'd like to punt this review to someone more familiar with the code. Any suggestions?

@ssomers
Copy link
Contributor Author

ssomers commented Jul 14, 2020

Well, at some point this one was interested in learning more...
r? @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 15, 2020

📌 Commit 2aa3133 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 16, 2020
…lacrum

Add and fix BTreeMap comments

No code changed (yet)
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 16, 2020
…arth

Rollup of 7 pull requests

Successful merges:

 - rust-lang#73421 (Clarify effect of orphan rule changes on From/Into)
 - rust-lang#74037 (Update reference to CONTRIBUTING.md)
 - rust-lang#74203 (Enforce the static symbol order.)
 - rust-lang#74295 (Add and fix BTreeMap comments)
 - rust-lang#74352 (Use local links in the alloc docs.)
 - rust-lang#74377 (Move libstd's default feature to libtest)
 - rust-lang#74381 (Update docs for str::as_bytes_mut.)

Failed merges:

r? @ghost
@bors bors merged commit 80a7a87 into rust-lang:master Jul 16, 2020
@ssomers ssomers deleted the btree_comments branch July 16, 2020 10:49
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants