Ayu theme: Use different background color for Run button #74501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in HTML/CSS/JS. Some changes occurred in HTML/CSS themes. |
rust-highfive
added
the
S-waiting-on-review
|
I copy the rule from #74371. |
|
Good idea! I agree that the run button should have a backing to make it easily recognizable. I don't like the outline, though. It feels very out-of-place. I would prefer it if we went with something like this: a.test-arrow {
font-size: 100%;
color: #788797;
border-radius: 4px;
background-color: rgba(57,175,215,0.09);
}
a.test-arrow:hover {
background-color: rgba(57,175,215,0.368);
color: #c5c5c5;
}Which looks like:
This is also more in line with what the existing themes do, and it works better on mobile aspect ratios:
The outline approach makes this even harder to read. |
Co-authored-by: Cldfire <cldfire@3grid.net>
GuillaumeGomez
approved these changes
Jul 20, 2020
|
Thanks! @bors: r+ rollup |
|
📌 Commit 0eff3d5 has been approved by |
bors
added
S-waiting-on-bors
tesuji
changed the title
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 20, 2020
…arth Rollup of 13 pull requests Successful merges: - rust-lang#72714 (Fix debug assertion in typeck) - rust-lang#73197 (Impl Default for ranges) - rust-lang#73323 (wf: check foreign fn decls for well-formedness) - rust-lang#74051 (disallow non-static lifetimes in const generics) - rust-lang#74376 (test caching opt_const_param_of on disc) - rust-lang#74501 (Ayu theme: Use different background color for Run button) - rust-lang#74505 (Fix search input focus in ayu theme) - rust-lang#74522 (Update sanitizer docs) - rust-lang#74546 (Fix duplicate maybe_uninit_extra attribute) - rust-lang#74552 (Stabilize TAU constant.) - rust-lang#74555 (Improve "important traits" popup display on mobile) - rust-lang#74557 (Fix an ICE on an invalid `binding @ ...` in a tuple struct pattern) - rust-lang#74561 (update backtrace-rs) Failed merges: r? @ghost
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it clearer that there is a button Run there.
Demo in #74501 (comment) .