Skip to content

[DO NOT MERGE] perf-test for #74069 #74592

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 2 commits into from

Conversation

rust-timer
Copy link
Collaborator

This is an automatically generated pull request (from here) to run perf tests for #74069 which merged in a rollup.

        r? @ghost

Original message:
Rollup merge of rust-lang#74069 - erikdesjardins:bad-niche, r=nikomatsakis

Compare tagged/niche-filling layout and pick the best one

Finishes up rust-lang#71045, and so fixes rust-lang#63866.

cc @eddyb
r? @nikomatsakis (since @eddyb wrote the first commit)
@rust-timer
Copy link
Collaborator Author

@bors try @rust-timer queue

        The try commit's (master) parent should be 8ad7bc3f428300aee6764f6e23527e19eb235e81. If it isn't, then please:

          * Stop this try build (`try-`).
          * Run `@rust-timer update-pr-for e775b4dbc4a991d60014225088c58eddd91f18cb`.
          * Rerun `bors try`.

        You do not need to reinvoke the queue command as long as the perf build hasn't yet started.

@rust-timer
Copy link
Collaborator Author

Awaiting bors try build completion

@Mark-Simulacrum
Copy link
Member

@bors try

It seems like we raced with GitHub's creation of the "pull request" merge commit...

@bors
Copy link
Collaborator

bors commented Jul 21, 2020

⌛ Trying commit e464d57 with merge cfade73820883adf654fe34fd6b0b03a99458a51...

@bors
Copy link
Collaborator

bors commented Jul 21, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: cfade73820883adf654fe34fd6b0b03a99458a51 (cfade73820883adf654fe34fd6b0b03a99458a51)

@rust-timer
Copy link
Collaborator Author

Queued cfade73820883adf654fe34fd6b0b03a99458a51 with parent 8ad7bc3, future comparison URL.

@rust-timer
Copy link
Collaborator Author

Finished benchmarking try commit (cfade73820883adf654fe34fd6b0b03a99458a51): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@Mark-Simulacrum
Copy link
Member

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants