A bundle of default method fixes and related changes #7471
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hods. This is done by adding a new notion of "vtable_self". We do not yet properly handle super traits. Closes rust-lang#7183.
…tions for each param.
This is work on rust-lang#7460. It does not properly handle certain cross crate situations, because we don't properly export vtable resolution information.
bors
added a commit
that referenced
this pull request
Jun 29, 2013
This fixes a bunch of default method bugs and restructures how vtable resolutions are represented. (It also adds a depth counter to llvm::type_to_str as a hacky work around for our circular llvm types. This is related in the sense that I needed to do it to make debug tracing not cause rustc to crash after running out of stack space.)
|
\o/ |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 19, 2021
Fix ICE in redundant_pattern_matching Fixes rust-lang#7410 changelog: Fix ICE in `redundant_pattern_matching` in `no_std` crates.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 19, 2021
Rustup r? `@ghost` Out of cycle sync for 2 ICE fixes rust-lang#7470 rust-lang#7471 rust-lang#7473 changelog: none
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bunch of default method bugs and restructures how vtable resolutions are represented.
(It also adds a depth counter to llvm::type_to_str as a hacky work around for our circular llvm types. This is related in the sense that I needed to do it to make debug tracing not cause rustc to crash after running out of stack space.)