-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Reland #74069 #74802
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Reland #74069 #74802
Conversation
@bors try @rust-timer queue Let's double check just in case that this is indeed performance neutral. |
Awaiting bors try build completion |
⌛ Trying commit 144b159 with merge 93a1b4821b7cb7b883a996d4787c3fd60fb4fe47... |
☀️ Try build successful - checks-actions, checks-azure |
Queued 93a1b4821b7cb7b883a996d4787c3fd60fb4fe47 with parent c709862, future comparison URL. |
Finished benchmarking try commit (93a1b4821b7cb7b883a996d4787c3fd60fb4fe47): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Perf effects are minimal, if anything a tiny improvement. |
@nnethercote or @eddyb, I think this is good to go, would someone mind r+ing? |
@bors r+ |
📌 Commit 144b159 has been approved by |
☀️ Test successful - checks-actions, checks-azure |
Investigation in #74716 has concluded that this PR is indeed not a regression (and in fact the rollup itself is not either).
This reverts the revert in #74611.
r? @nnethercote cc @eddyb