Skip to content

fix part of comparison that would always evaluate to "true", probably an oversight #74986

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2020
Merged

fix part of comparison that would always evaluate to "true", probably an oversight #74986

merged 1 commit into from
Aug 1, 2020

Conversation

matthiaskrgr
Copy link
Member

@rust-highfive
Copy link
Contributor

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 31, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Jul 31, 2020

@bors r+ rollup

ugh, I should really look into running clippy on rustc ^^

@bors
Copy link
Collaborator

bors commented Jul 31, 2020

📌 Commit 8a5654f has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2020
@JohnTitor JohnTitor mentioned this pull request Jul 31, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 31, 2020
@bors
Auto merge of rust-lang#74994 - JohnTitor:rollup-eknaekv, r=JohnTitor
b544b43 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#74644 (Remove `linked_list_extras` methods.)
 - rust-lang#74968 (Run all tests if have no specified tests)
 - rust-lang#74982 (1.45.2 release notes)
 - rust-lang#74984 (Miri: fix ICE when unwinding past topmost stack frame)
 - rust-lang#74986 (fix part of comparison that would always evaluate to "true", probably an oversight)
 - rust-lang#74991 (Fix Const-Generic Cycle ICE rust-lang#74199)

Failed merges:

r? @ghost
@bors bors merged commit ff5ccc8 into rust-lang:master Aug 1, 2020
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
@matthiaskrgr matthiaskrgr deleted the cmp_true branch January 25, 2025 09:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
5 participants
@matthiaskrgr @rust-highfive @oli-obk @bors @cuviper