Skip to content

Introduce an abstraction for EvaluationCache and SelectionCache #75055

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Aug 3, 2020

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Aug 2, 2020

The small duplicated code has been moved to librustc_query_system.

The remaining changes are some cleanups of structural impls.

@rust-highfive
Copy link
Contributor

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 2, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Aug 2, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 2, 2020

📌 Commit 058e021 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2020
@bors
Copy link
Collaborator

bors commented Aug 3, 2020

⌛ Testing commit 058e021 with merge 7637cbb...

@bors
Copy link
Collaborator

bors commented Aug 3, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: oli-obk
Pushing 7637cbb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 3, 2020
@bors bors merged commit 7637cbb into rust-lang:master Aug 3, 2020
@cjgillot cjgillot deleted the clean-cache branch August 3, 2020 12:34
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants