Skip to content

Clean up E0745 #75140

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2020
Merged

Clean up E0745 #75140

merged 1 commit into from
Aug 5, 2020

Conversation

GuillaumeGomez
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2020
pickfire
pickfire approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@GuillaumeGomez
Copy link
Member Author

@bors: r=pickfire rollup

@bors
Copy link
Collaborator

bors commented Aug 4, 2020

📌 Commit 0275cd7 has been approved by pickfire

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2020
@bors
Copy link
Collaborator

bors commented Aug 4, 2020

⌛ Testing commit 0275cd7 with merge 039b2282e19ce81f6df39fbb8b95029b67da9c27...

@rust-log-analyzer
Copy link
Collaborator

The job i686-msvc-2 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@bors
Copy link
Collaborator

bors commented Aug 4, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 4, 2020
@JohnTitor
Copy link
Member

The log says:

2020-08-04T17:05:35.4404917Z Caused by:
2020-08-04T17:05:35.4405087Z   error inflating zlib stream; class=Zlib (5)
2020-08-04T17:05:35.4484019Z failed to run: D:\a\rust\rust\build\i686-pc-windows-msvc\stage0\bin\cargo.exe build --manifest-path D:\a\rust\rust\src/bootstrap/Cargo.toml --locked
2020-08-04T17:05:35.4485235Z Build completed unsuccessfully in 0:00:23
2020-08-04T17:05:35.4598968Z make: *** [Makefile:60: prepare] Error 1
2020-08-04T17:05:39.4794868Z Command failed. Attempt 5/5:
2020-08-04T17:05:39.8494605Z     Updating crates.io index
2020-08-04T17:06:02.8103572Z error: failed to get `cc` as a dependency of package `bootstrap v0.0.0 (D:\a\rust\rust\src\bootstrap)`
2020-08-04T17:06:02.8104465Z 
2020-08-04T17:06:02.8105895Z Caused by:
2020-08-04T17:06:02.8106804Z   failed to fetch `https://github.com/rust-lang/crates.io-index`
2020-08-04T17:06:02.8106980Z 
2020-08-04T17:06:02.8107125Z Caused by:
2020-08-04T17:06:02.8107525Z   error inflating zlib stream; class=Zlib (5)
2020-08-04T17:06:02.8187166Z failed to run: D:\a\rust\rust\build\i686-pc-windows-msvc\stage0\bin\cargo.exe build --manifest-path D:\a\rust\rust\src/bootstrap/Cargo.toml --locked
2020-08-04T17:06:02.8187828Z Build completed unsuccessfully in 0:00:23
2020-08-04T17:06:02.8298322Z make: *** [Makefile:60: prepare] Error 1
2020-08-04T17:06:02.8307850Z The command has failed after 5 attempts.

It's spurious, @bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Aug 5, 2020
@Manishearth
Rollup merge of rust-lang#75140 - GuillaumeGomez:cleanup-e0745, r=pic…
74f3561 
…kfire

Clean up E0745

r? @Dylan-DPC
@Manishearth Manishearth mentioned this pull request Aug 5, 2020
Closed
@JohnTitor JohnTitor mentioned this pull request Aug 5, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 5, 2020
@bors
Auto merge of rust-lang#75174 - JohnTitor:rollup-z9djftk, r=JohnTitor
119d2a1 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#75139 (Remove log alias from librustdoc)
 - rust-lang#75140 (Clean up E0745)
 - rust-lang#75149 (Correct a typo in interpret/memory.rs)
 - rust-lang#75152 (Replace `Memoryblock` with `NonNull<[u8]>`)
 - rust-lang#75168 (Update books)

Failed merges:

r? @ghost
@bors bors merged commit 008228a into rust-lang:master Aug 5, 2020
@GuillaumeGomez GuillaumeGomez deleted the cleanup-e0745 branch August 5, 2020 07:51
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pickfire pickfire pickfire approved these changes

Assignees

@Dylan-DPC-zz Dylan-DPC-zz

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
8 participants
@GuillaumeGomez @bors @rust-log-analyzer @JohnTitor @pickfire @cuviper @rust-highfive @Dylan-DPC-zz