Skip to content

make MaybeUninit::as_(mut_)ptr const #75250

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Aug 8, 2020
Merged

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Aug 7, 2020

I think it was just an oversight that they are not const yet.

I also changed their implementation as the old one created references to uninitialized memory.^^

@rust-highfive
Copy link
Contributor

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 7, 2020
@RalfJung RalfJung force-pushed the uninit-const-ptr branch 2 times, most recently from bc4dc26 to fcf4b35 Compare August 7, 2020 10:29
@oli-obk
Copy link
Contributor

oli-obk commented Aug 7, 2020

r? @oli-obk

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 7, 2020

📌 Commit fcf4b35515343db6361a4ed63ce1d77bf74e038f has been approved by oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned shepmaster Aug 7, 2020
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Aug 7, 2020

@bors rollup

@RalfJung
Copy link
Member Author

RalfJung commented Aug 7, 2020

blessed fmt
@bors r=oli-obk

@bors
Copy link
Collaborator

bors commented Aug 7, 2020

📌 Commit ec5d78d has been approved by oli-obk

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 8, 2020
Rollup of 7 pull requests

Successful merges:

 - rust-lang#75224 (Don't call a function in function-arguments-naked.rs)
 - rust-lang#75237 (Display elided lifetime for non-reference type in doc)
 - rust-lang#75250 (make MaybeUninit::as_(mut_)ptr const)
 - rust-lang#75253 (clean up const-hacks in int endianess conversion functions)
 - rust-lang#75259 (Add missing backtick)
 - rust-lang#75267 (Small cleanup)
 - rust-lang#75270 (fix a couple of clippy findings)

Failed merges:

r? @ghost
@bors bors merged commit b032a15 into rust-lang:master Aug 8, 2020
@RalfJung RalfJung deleted the uninit-const-ptr branch August 11, 2020 07:06
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants