Skip to content

Update hashbrown to 0.8.2 #75306

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Aug 9, 2020
Merged

Update hashbrown to 0.8.2 #75306

merged 1 commit into from
Aug 9, 2020

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Aug 8, 2020

Includes:

r? @Mark-Simulacrum

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 8, 2020
@Amanieu
Copy link
Member Author

Amanieu commented Aug 8, 2020

@bors rollup=never

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 8, 2020

📌 Commit 99f0052 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2020
@Amanieu
Copy link
Member Author

Amanieu commented Aug 8, 2020

cc @nnethercote

@Mark-Simulacrum
Copy link
Member

I figured we could land this and check perf after it lands, by the way - it won't get rolled up already (thanks!) and shouldn't be a regression.

@bors
Copy link
Collaborator

bors commented Aug 9, 2020

⌛ Testing commit 99f0052 with merge aced185...

@bors
Copy link
Collaborator

bors commented Aug 9, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing aced185 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 9, 2020
@bors bors merged commit aced185 into rust-lang:master Aug 9, 2020
@nnethercote
Copy link
Contributor

nnethercote commented Aug 9, 2020

Perf results from the landing. A bit weird; lots of improvements but some regressions as well, most in the incr-patched runs. I'm disappointed it's not a clearer and more uniform win, like I saw in my local results.

@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants