Skip to content

Move to intra-doc links in library/core/src/time.rs #75348

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 10, 2020
Merged

Move to intra-doc links in library/core/src/time.rs #75348

merged 3 commits into from
Aug 10, 2020

Conversation

denisvasilik
Copy link
Contributor

@denisvasilik denisvasilik commented Aug 9, 2020 •
edited by Mark-Simulacrum
Loading

Helps with #75080.

@rustbot rustbot added A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 9, 2020
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2020
@Mark-Simulacrum
Copy link
Member

r? @jyn514 (but looks good to me)

jyn514
jyn514 reviewed Aug 9, 2020
View reviewed changes
denisvasilik and others added 2 commits August 9, 2020 23:12
@denisvasilik
Remove liNone as it is in the prelude
ce24421
@denisvasilik
Add link for Duration
9e71c13 
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
@jyn514
Copy link
Member

jyn514 commented Aug 9, 2020

@bors r+ rollup

Thanks for the PR!

@bors
Copy link
Collaborator

bors commented Aug 9, 2020

📌 Commit 9e71c13 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2020
@JohnTitor JohnTitor mentioned this pull request Aug 10, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 10, 2020
@bors
Auto merge of rust-lang#75351 - JohnTitor:rollup-q9udsyx, r=JohnTitor
cee62c1 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#74200 (Std panicking unsafe block in unsafe fn)
 - rust-lang#75286 (Add additional case for Path starts with)
 - rust-lang#75318 (Resolve `char` as a primitive even if there is a module in scope)
 - rust-lang#75320 (Detect likely `for foo of bar` JS syntax)
 - rust-lang#75328 (Cleanup E0749)
 - rust-lang#75344 (Rename "Important traits" to "Notable traits")
 - rust-lang#75348 (Move to intra-doc links in library/core/src/time.rs)
 - rust-lang#75350 (Do not ICE when lowering invalid extern fn with bodies)

Failed merges:

r? @ghost
@bors bors merged commit 64d7109 into rust-lang:master Aug 10, 2020
@jyn514 jyn514 removed the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Aug 25, 2020
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees

@jyn514 jyn514

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
7 participants
@denisvasilik @rust-highfive @Mark-Simulacrum @jyn514 @bors @cuviper @rustbot