Skip to content

Tiny cleanup, remove unnecessary unwrap #75353

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2020
Merged

Tiny cleanup, remove unnecessary unwrap #75353

merged 1 commit into from
Aug 11, 2020

Conversation

estebank
Copy link
Contributor

Remove unnecessary unwrap.

@estebank
Small cleanup
7e01809 
Remove unnecessary `unwrap`.
@rust-highfive
Copy link
Contributor

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 10, 2020
@jyn514
Copy link
Member

jyn514 commented Aug 10, 2020

@bors r+ rollup

Is it possible to add a lint for this? I asked for something similar in #75235 but this is a non-exhaustive match so it would be somewhat harder than the case there ... maybe a clippy lint?

@bors
Copy link
Collaborator

bors commented Aug 10, 2020

📌 Commit 7e01809 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2020
@jyn514 jyn514 added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Aug 10, 2020
@estebank
Copy link
Contributor Author

@jyn514 that would be very useful, but I worry that the level of analysis needed might be to hard to implement.

@JohnTitor JohnTitor mentioned this pull request Aug 11, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 11, 2020
@bors
Auto merge of rust-lang#75388 - JohnTitor:rollup-9tgkxnl, r=JohnTitor
4b9ac51 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#74744 (Update RELEASES.md for 1.46.0)
 - rust-lang#75085 (Transmute big endian `s6_addr` and `[u16; 8]`)
 - rust-lang#75226 (Miri: Renamed "undef" to "uninit")
 - rust-lang#75333 (polymorphize: constrain unevaluated const handling)
 - rust-lang#75338 (move stack size check to const_eval machine)
 - rust-lang#75347 (Rustdoc: Fix natural ordering to look at all numbers.)
 - rust-lang#75352 (Tweak conditions for E0026 and E0769)
 - rust-lang#75353 (Tiny cleanup, remove unnecessary `unwrap`)
 - rust-lang#75359 (unused_delims: trim expr)
 - rust-lang#75360 (Add sample fix for E0749)

Failed merges:

r? @ghost
@bors bors merged commit 0a8d4db into rust-lang:master Aug 11, 2020
@estebank estebank deleted the tiny branch November 9, 2023 05:16
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@matthewjasper matthewjasper

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
6 participants
@estebank @rust-highfive @jyn514 @bors @cuviper @matthewjasper