Skip to content

Requested changes to [*mut T|*const T]::set_ptr_value #75407

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Requested changes to [*mut T|*const T]::set_ptr_value #75407

merged 1 commit into from
Aug 11, 2020

Conversation

oliver-giersch
Copy link
Contributor

This is a follow-up to PR #74774 (tracking issue #75091), acting on some change requests made after approval:

  • adds #[must_use] attribute
  • changes type of val pointer argument from () to u8
  • adjusts documentation mentioning pointer provenance

@rust-highfive
Copy link
Contributor

r? @hanna-kruppe

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 11, 2020
@RalfJung
Copy link
Member

Thanks!
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 11, 2020

📌 Commit 19c9674 has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 11, 2020
Rollup of 7 pull requests

Successful merges:

 - rust-lang#75036 (Prefer pattern matching over indexing)
 - rust-lang#75378 (Introduce `rustc_lexer::is_ident` and use it in couple of places)
 - rust-lang#75393 (Fully handle "?" shortcut)
 - rust-lang#75403 (Update comment for function)
 - rust-lang#75407 (Requested changes to [*mut T|*const T]::set_ptr_value)
 - rust-lang#75408 (Update MinGW comments in ci.yml)
 - rust-lang#75409 (Fix range term in alloc vec doc)

Failed merges:

r? @ghost
@bors bors merged commit 06eb274 into rust-lang:master Aug 11, 2020
@oliver-giersch oliver-giersch deleted the set_ptr_value branch August 12, 2020 07:11
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants