-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Adjust installation place for compiler docs #75593
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adjust installation place for compiler docs #75593
Conversation
This avoids conflicts when installing with rustup; rustup does not currently support overlapping installations.
@bors try Let's get initial artifacts prepared so we can test this. This might run into some problems with RCS's nightly-rustc promotion. I think it should be fine though and just upload to nightly-rustc/rustc until we can fix that (which should be easy, we just adjust the "tarball_dir" to include the newly added directory). cc @pietroalbini -- I imagine what we'll want to do here is merge this and then merge rust-lang/rust-central-station#912 quickly thereafter, but if there's a better approach happy to use that too. |
…t-overlap, r=<try> Adjust installation place for compiler docs This avoids conflicts when installing with rustup; rustup does not currently support overlapping installations. r? @matthiaskrgr
☀️ Try build successful - checks-actions, checks-azure |
I tried to install a lot of different components now and the toolchain-installer-master did not find any conflicts: r=me I guess? |
I am going to r? @pietroalbini on this -- in particular how to deploy RCS in sync with this patch I'm a bit unclear on. I've kicked off promotion for 532ad7b on rust-central-station though. |
Left a comment in RCS on a possible transition plan. |
r=me once RCS is deployed |
RCS has been deployed, so let's @bors r+ this |
📌 Commit 172e67e has been approved by |
er, @bors r- r=pietroalbini |
📌 Commit 172e67e has been approved by |
…not-overlap, r=pietroalbini Adjust installation place for compiler docs This avoids conflicts when installing with rustup; rustup does not currently support overlapping installations. r? @matthiaskrgr
Rollup of 7 pull requests Successful merges: - rust-lang#75069 (move const param structural match checks to wfcheck) - rust-lang#75587 (mir building: fix some comments) - rust-lang#75593 (Adjust installation place for compiler docs) - rust-lang#75648 (Make OnceCell<T> transparent to dropck) - rust-lang#75649 (Fix intra-doc links for inherent impls that are both lang items and not the default impl) - rust-lang#75674 (Move to intra doc links for std::io) - rust-lang#75696 (Remove `#[cfg(miri)]` from OnceCell tests) Failed merges: r? @ghost
This did not fix the issue unfortunately :/
|
This avoids conflicts when installing with rustup; rustup does not currently
support overlapping installations.
r? @matthiaskrgr