-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Rename rustc_lexer::TokenKind::Not to Bang #75743
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me when CI passes
@bors r=davidtwco rollup |
📌 Commit ec9bf7e6599cd22ee449ddb15466e76fe131e3e6 has been approved by |
Why not |
@bors r- Good question, I think Bang would be better |
All other tokens are named by the punctuation they use, rather than by semantics operation they stand for. `!` is the only exception to the rule, let's fix it.
@bors r=davidtwco rollup |
📌 Commit 5299297 has been approved by |
PR title need to change too. |
Rollup of 8 pull requests Successful merges: - rust-lang#75672 (Move to intra-doc links for task.rs and vec.rs) - rust-lang#75702 (Clean up E0759 explanation) - rust-lang#75703 (Enable stack-overflow detection on musl for non-main threads) - rust-lang#75710 (Fix bad printing of const-eval queries) - rust-lang#75716 (Upgrade Emscripten on CI to 1.39.20 ) - rust-lang#75731 (Suppress ty::Float in MIR comments of ty::Const) - rust-lang#75733 (Remove duplicated alloc vec bench push_all_move) - rust-lang#75743 (Rename rustc_lexer::TokenKind::Not to Bang) Failed merges: r? @ghost
All other tokens are named by the punctuation they use, rather than
by semantics operation they stand for.
!
is the only exception tothe rule, let's fix it.