Skip to content

Fix swapped stability attributes for rustdoc lints #75953

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2020
Merged

Fix swapped stability attributes for rustdoc lints #75953

merged 1 commit into from
Aug 27, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Aug 26, 2020 •
edited
Loading

This fixes a regression introduced in #74855. Previously, missing_doc_code_examples would be run on stable and private_doc_tests would only be run on nightly. Now, it correctly does the reverse.
Closes #75951.
r? @ehuss

@jyn514 jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-doctests Area: Documentation tests, run by rustdoc labels Aug 26, 2020
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 26, 2020
@jyn514 jyn514 changed the title Fix swapped stability attributes Fix swapped stability attributes for rustdoc lints Aug 26, 2020
@jyn514
Copy link
Member Author

jyn514 commented Aug 26, 2020 •
edited
Loading

I have no idea how to test this, suggestions appreciated. I also asked in https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/How.20do.20I.20test.20if.20a.20lint.20runs.20on.20stable.20and.20beta.3F and https://discordapp.com/channels/442252698964721669/459149231702278154/748257833010593944.

@jyn514 jyn514 added the A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. label Aug 26, 2020
@jyn514
Copy link
Member Author

jyn514 commented Aug 26, 2020

How do I propose that this be backported to beta? Just add the beta-nominated tag?

@jyn514 jyn514 added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 26, 2020
@jyn514
Copy link
Member Author

jyn514 commented Aug 26, 2020

cc @rust-lang/rustdoc - are you ok with backporting? The fix is pretty simple so I don't see any reason not to other than the missing test.

@jyn514
Fix swapped stability attributes
29399fa 
This fixes a regression introduced in
rust-lang#74855.
@jyn514
Copy link
Member Author

jyn514 commented Aug 26, 2020 •
edited
Loading

As a larger point of discussion I'd like to propose slowly requiring #![feature()] for any nightly features, which would help avoid this sort of thing in the future. But I'm not making any change like that here.

@GuillaumeGomez
Copy link
Member

You broke my lint? :o Since @Manishearth was the one reviewing the original, I'll let them handle this one as well. Otherwise looks good to me!

@jyn514
Copy link
Member Author

jyn514 commented Aug 26, 2020

@GuillaumeGomez what do you think about backporting the fix to beta?

@GuillaumeGomez
Copy link
Member

If the lint is supposed to be nightly only, I'd prefer that it remains that way, so I agree with the backport.

@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 26, 2020

📌 Commit 29399fa has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2020
@jyn514
Copy link
Member Author

jyn514 commented Aug 26, 2020

@Manishearth are you ok with a backport?

@Manishearth
Copy link
Member

Yep! Release team may decide to say no but they usually don't.

@jyn514 jyn514 added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Aug 26, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Aug 26, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 27, 2020
@bors
Auto merge of rust-lang#75966 - Dylan-DPC:rollup-srfpces, r=Dylan-DPC
09b06f9 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#74730 (Hexagon libstd: update type defs)
 - rust-lang#75758 (Fixes for VxWorks)
 - rust-lang#75780 (Unconfuse Unpin docs a bit)
 - rust-lang#75806 (Prevent automatic page change when using history)
 - rust-lang#75818 (Update docs for SystemTime Windows implementation)
 - rust-lang#75837 (Fix font color for help button in ayu and dark themes)
 - rust-lang#75870 (Unify theme choices border color in ayu theme)
 - rust-lang#75875 (Shorten liballoc vec resize intra-doc link)
 - rust-lang#75953 (Fix swapped stability attributes for rustdoc lints)
 - rust-lang#75958 (Avoid function-scoping global variables)

Failed merges:

r? @ghost
@bors bors merged commit c2a0168 into rust-lang:master Aug 27, 2020
@jyn514 jyn514 deleted the missing-lints branch August 27, 2020 03:16
@jyn514 jyn514 added beta-nominated Nominated for backporting to the compiler in the beta channel. and removed beta-accepted Accepted for backporting to the compiler in the beta channel. labels Aug 28, 2020
@jyn514 jyn514 added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 28, 2020
@jyn514 jyn514 mentioned this pull request Aug 28, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 28, 2020
@bors
Auto merge of rust-lang#76032 - jyn514:lint-backport, r=Mark-Simulacrum
84b047b 
[beta] Backport fix for swapped stability attributes

This backports the only commit in rust-lang#75953, fixing one unstable lint which ran on stable and one stable lint which only ran on nightly. This change can be replicated with
```
git fetch origin
git checkout origin/beta
git cherry-pick 29399fa
```
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 17, 2020
@Mark-Simulacrum Mark-Simulacrum added this to the 1.47.0 milestone Sep 17, 2020
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Sep 17, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@ehuss ehuss

Labels
A-doctests Area: Documentation tests, run by rustdoc A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.

rustdoc: private_doc_tests lint no longer fires on stable
7 participants
@jyn514 @GuillaumeGomez @Manishearth @bors @ehuss @Mark-Simulacrum @rust-highfive