Skip to content

Use explicit intra-doc link in path for Vec resize #76069

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2020
Merged

Use explicit intra-doc link in path for Vec resize #76069

merged 1 commit into from
Aug 31, 2020

Conversation

pickfire
Copy link
Contributor

r? @jyn514

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 29, 2020
jyn514
jyn514 reviewed Aug 29, 2020
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I have similar concerns as in #75945. Is the documentation actually more clear now? We should optimize for the reader, not for the writer.

@jyn514 jyn514 added A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Aug 29, 2020
@pickfire
Copy link
Contributor Author

pickfire commented Aug 29, 2020 •
edited
Loading

Wouldn't using the explicit Vec::resize makes it easier to read compared to just resize?

@jyn514
Copy link
Member

jyn514 commented Aug 29, 2020

Ok, that makes sense to me.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 29, 2020

📌 Commit 237c500 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2020
matklad added a commit to matklad/rust that referenced this pull request Aug 31, 2020
@matklad
Rollup merge of rust-lang#76069 - pickfire:patch-16, r=jyn514
7e13583 
Use explicit intra-doc link in path for Vec resize

r? @jyn514
This was referenced Aug 31, 2020
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 31, 2020
@bors
Auto merge of rust-lang#76153 - matklad:rollup-vlblfup, r=matklad
3b4797c 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#75969 (Switch to intra-doc links in core/src/{convert,iter}/mod.rs)
 - rust-lang#76023 (Liballoc extend use intra doc link)
 - rust-lang#76033 (Add missing hyphen)
 - rust-lang#76052 (rust-langGH-66816:  Remove disable attr before return)
 - rust-lang#76055 (Keep doc standard for Vec DrainFilter)
 - rust-lang#76058 (Use assertions on Vec doc)
 - rust-lang#76069 (Use explicit intra-doc link in path for Vec resize)
 - rust-lang#76117 (Update README.md)
 - rust-lang#76134 (Update MinGW instructions to include ninja)

Failed merges:

r? @ghost
@bors bors merged commit 13c4f04 into rust-lang:master Aug 31, 2020
@jyn514 jyn514 added merged-by-bors This PR was explicitly merged by bors. and removed merged-by-bors This PR was explicitly merged by bors. labels Aug 31, 2020
@pickfire pickfire deleted the patch-16 branch August 31, 2020 14:31
@cuviper cuviper added this to the 1.48.0 milestone Nov 17, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees

@jyn514 jyn514

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
5 participants
@pickfire @jyn514 @bors @cuviper @rust-highfive