Function to convert OpenOptions to c_int #76110

FedericoPonzi · 2020-08-30T14:28:31Z

Fixes: #74943
The creation_mode and access_mode function were already available in the OpenOptions struct, but currently private. I've added a new free functions to unix/fs.rs which takes the OpenOptions, and returns the c_int to be used as parameter for the open call.

rust-highfive · 2020-08-30T14:28:33Z

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

FedericoPonzi · 2020-08-30T14:28:59Z

r? @withoutboats

FedericoPonzi · 2020-08-30T14:45:44Z

I would like some guidance on the following:

Is that the right place to put the requested function?
How can I fix the CI error? Currently failing with error: function is never used: get_openopetions_as_cint`.
Were can I put a test for it?

library/std/src/sys/unix/fs.rs

Co-authored-by: Ivan Tham <pickfire@riseup.net>

joshtriplett

I added a couple of comments.

Also, you should add tests near the existing tests for OpenOptionsExt.

library/std/src/sys/unix/fs.rs

FedericoPonzi · 2020-08-30T20:49:01Z

I added a couple of comments.

Also, you should add tests near the existing tests for OpenOptionsExt.

Thanks a lot for your comments! I've added the as_flags method to OpenOptionsExt in unix/ext/fs.rs. Since the get_access_mode and get_creation_mode are private to the OpenOptions struct thus I had to duplicate a bit of the code.

I currently have one last issue, I cannot seem to find the location of the tests for OpenOptionsExt, could you please tell me where can I find them?

joshtriplett · 2020-08-30T21:38:31Z

Since the get_access_mode and get_creation_mode are private to the OpenOptions struct thus I had to duplicate a bit of the code.

Similar to the other methods of OpenOptionsExt, you should implement this as a call to self.as_inne().as_flags(), which calls the corresponding method on the OpenOptions implemented in at library/std/src/sys/unix/fs.rs. That's where get_access_mode and get_creation_mode are defined, so you'll be able to call them and avoid the duplication.

I currently have one last issue, I cannot seem to find the location of the tests for OpenOptionsExt, could you please tell me where can I find them?

I'd suggest adding doctests to the method, like the other methods of OpenOptionsExt have.

…ust into convert-openoptions-cint

library/std/src/sys/unix/ext/fs.rs

library/std/src/sys/unix/fs.rs

library/std/src/sys/unix/ext/fs.rs

library/std/src/sys/unix/fs.rs

library/std/src/sys/unix/ext/fs.rs

library/std/src/sys/unix/fs.rs

library/std/src/sys/unix/ext/fs.rs

FedericoPonzi · 2020-09-07T08:23:02Z

r? @joshtriplett
I've r you because you already approved the PR, and this hadn't any traffic for a while now and I'm not sure how to move this forward. Hopefully it's fine for you, thanks!

library/std/src/sys/unix/ext/fs.rs

jyn514 · 2020-09-22T12:14:35Z

@bors r=@joshtriplett

bors · 2020-09-22T12:14:37Z

📌 Commit 2f51922 has been approved by JoshTriplet

bors · 2020-09-22T12:14:50Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Add a changelog for x.py and nag contributors until they read it #76626

bors · 2020-09-22T12:14:51Z

📌 Commit 2f51922 has been approved by JoshTriplett

bors · 2020-09-22T13:02:08Z

⌛ Testing commit 2f51922 with merge e0bc267...

bors · 2020-09-22T15:16:03Z

☀️ Test successful - checks-actions, checks-azure
Approved by: JoshTriplett
Pushing e0bc267 to master...

…tions-cint, r=dtolnay Revert "Function to convert OpenOptions to c_int" Reverts rust-lang#76110. This broke Rust's stability guarantees. Closes rust-lang#77089. r? `@joshtriplett`

initial implementation of OpenOptions to c_int

27c90b8

rust-highfive assigned Mark-Simulacrum Aug 30, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 30, 2020

rust-highfive assigned withoutboats and unassigned Mark-Simulacrum Aug 30, 2020

pickfire reviewed Aug 30, 2020

View reviewed changes

library/std/src/sys/unix/fs.rs Outdated Show resolved Hide resolved

Fix typo get openoptions function name

eb3906b

Co-authored-by: Ivan Tham <pickfire@riseup.net>

joshtriplett requested changes Aug 30, 2020

View reviewed changes

library/std/src/sys/unix/fs.rs Outdated Show resolved Hide resolved

library/std/src/sys/unix/fs.rs Outdated Show resolved Hide resolved

Federico Ponzi added 2 commits August 31, 2020 15:48

Add as_flag function to the OpenOptionsExt struct

1bc0627

Merge branch 'convert-openoptions-cint' of github.com:FedericoPonzi/r…

2c9e27b

…ust into convert-openoptions-cint

pickfire reviewed Aug 31, 2020

View reviewed changes

library/std/src/sys/unix/ext/fs.rs Outdated Show resolved Hide resolved

pickfire reviewed Aug 31, 2020

View reviewed changes

library/std/src/sys/unix/fs.rs Show resolved Hide resolved

pickfire reviewed Aug 31, 2020

View reviewed changes

library/std/src/sys/unix/ext/fs.rs Show resolved Hide resolved

pickfire reviewed Aug 31, 2020

View reviewed changes

library/std/src/sys/unix/ext/fs.rs Outdated Show resolved Hide resolved

pickfire reviewed Aug 31, 2020

View reviewed changes

library/std/src/sys/unix/ext/fs.rs Show resolved Hide resolved

pickfire reviewed Aug 31, 2020

View reviewed changes

library/std/src/sys/unix/ext/fs.rs Outdated Show resolved Hide resolved

pickfire reviewed Aug 31, 2020

View reviewed changes

library/std/src/sys/unix/ext/fs.rs Show resolved Hide resolved

FedericoPonzi requested a review from joshtriplett August 31, 2020 20:40

Update OpenOptions::as_flags docs, and minor styling

7c1e5c1

pickfire reviewed Sep 1, 2020

View reviewed changes

library/std/src/sys/unix/fs.rs Show resolved Hide resolved

pickfire reviewed Sep 2, 2020

View reviewed changes

library/std/src/sys/unix/ext/fs.rs Outdated Show resolved Hide resolved

pickfire reviewed Sep 2, 2020

View reviewed changes

library/std/src/sys/unix/ext/fs.rs Outdated Show resolved Hide resolved

pickfire reviewed Sep 2, 2020

View reviewed changes

library/std/src/sys/unix/fs.rs Show resolved Hide resolved

pickfire reviewed Sep 2, 2020

View reviewed changes

library/std/src/sys/unix/ext/fs.rs Outdated Show resolved Hide resolved

Update docs of OpenOptions::as_flags

321b680

joshtriplett approved these changes Sep 4, 2020

View reviewed changes

rust-highfive assigned joshtriplett and unassigned withoutboats Sep 7, 2020

jyn514 added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Sep 15, 2020

jyn514 reviewed Sep 15, 2020

View reviewed changes

library/std/src/sys/unix/ext/fs.rs Outdated Show resolved Hide resolved

FedericoPonzi mentioned this pull request Sep 16, 2020

Tracking Issue for OpenOptionsExt::as_flags #76801

Open

2 tasks

Federico Ponzi added 2 commits September 16, 2020 19:40

Sets as_flags as unstable

70292d4

enable unstable open_options_ext_as_flags feature in doc comments

2f51922

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 22, 2020

bors merged commit e0bc267 into rust-lang:master Sep 22, 2020

rustbot added this to the 1.48.0 milestone Sep 22, 2020

FedericoPonzi deleted the convert-openoptions-cint branch September 22, 2020 15:30

dtolnay mentioned this pull request Sep 23, 2020

Regression in nightly-2020-09-23: "missing as_flags in implementation" of OpenOptionsExt #77089

Closed

jyn514 mentioned this pull request Sep 23, 2020

Revert "Function to convert OpenOptions to c_int" #77090

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Function to convert OpenOptions to c_int #76110

Function to convert OpenOptions to c_int #76110

FedericoPonzi commented Aug 30, 2020

rust-highfive commented Aug 30, 2020

FedericoPonzi commented Aug 30, 2020

FedericoPonzi commented Aug 30, 2020

joshtriplett left a comment

FedericoPonzi commented Aug 30, 2020

joshtriplett commented Aug 30, 2020 •

edited

Loading

FedericoPonzi commented Sep 7, 2020 •

edited

Loading

jyn514 commented Sep 22, 2020 •

edited

Loading

bors commented Sep 22, 2020

bors commented Sep 22, 2020

bors commented Sep 22, 2020

bors commented Sep 22, 2020

bors commented Sep 22, 2020

Function to convert OpenOptions to c_int #76110

Function to convert OpenOptions to c_int #76110

Conversation

FedericoPonzi commented Aug 30, 2020

rust-highfive commented Aug 30, 2020

FedericoPonzi commented Aug 30, 2020

FedericoPonzi commented Aug 30, 2020

joshtriplett left a comment

Choose a reason for hiding this comment

FedericoPonzi commented Aug 30, 2020

joshtriplett commented Aug 30, 2020 • edited Loading

FedericoPonzi commented Sep 7, 2020 • edited Loading

jyn514 commented Sep 22, 2020 • edited Loading

bors commented Sep 22, 2020

bors commented Sep 22, 2020

bors commented Sep 22, 2020

bors commented Sep 22, 2020

bors commented Sep 22, 2020

joshtriplett commented Aug 30, 2020 •

edited

Loading

FedericoPonzi commented Sep 7, 2020 •

edited

Loading

jyn514 commented Sep 22, 2020 •

edited

Loading