Improved the MIR spanview output #76313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
richkadel
force-pushed
the
mir-spanview-2
branch
2 times, most recently
from
f70cf8e to
9c0afd2
Compare
* Adds missing "tail" spans (spans that continue beyond the end of overlapping spans) * Adds a caret to highlight empty spans associated with MIR elements that have a position, but otherwise would not be visible. * Adds visual pointing brackets at the beginning and end of each span
richkadel
force-pushed
the
mir-spanview-2
branch
from
9c0afd2 to
9046a93
Compare
|
@wesleywiser @tmandry - Welcome back from the holiday! I'm just re-pinging this CL again so its still in your queue. Thanks! |
wesleywiser
approved these changes
Sep 9, 2020
|
@richkadel Thanks for the ping! @bors r+ |
|
📌 Commit 9046a93 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 9046a93 with merge 70279296e1ca9bce9f195e8120420608631be470... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
On unrelated test. @wesleywiser - Looks spurious |
|
@bors retry |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 9, 2020
Rollup of 14 pull requests Successful merges: - rust-lang#75094 (Add `-Z combine_cgu` flag) - rust-lang#75984 (Improve unresolved use error message) - rust-lang#76141 (Address review comments about config.toml from rustc-dev-guide PR) - rust-lang#76313 (Improved the MIR spanview output) - rust-lang#76430 (Add align to rustc-attrs unstable book) - rust-lang#76465 (Add a script to automatically update Rust/Clang versions in documentation) - rust-lang#76473 (Add missed spaces to GCC-WARNING.txt) - rust-lang#76481 (Convert repetitive target_pointer_width checks to const solution.) - rust-lang#76493 (Remove a stray ignore-tidy-undocumented-unsafe) - rust-lang#76504 (Capitalize safety comments) - rust-lang#76515 (SessionDiagnostic: Fix non-determinism in generated format string.) - rust-lang#76516 (Enable GitHub Releases synchronization) - rust-lang#76522 (remove redundant clones) - rust-lang#76523 (Remove unused PlaceContext::NonUse(NonUseContext::Coverage)) Failed merges: r? `@ghost`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overlapping spans)
that have a position, but otherwise would not be visible.
r? @tmandry
FYI: @wesleywiser