-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Make rustdoc output deterministic for UI tests #76445
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Well, seems like the only way to do it so I guess it's fine. 👍 |
@bors r+ p=1 Causing spurious failures It seems like something like |
📌 Commit dd8d0d578af62fbfc95b29ee8000c03cf746a1aa has been approved by |
I'm not sure that rustdoc respects |
⌛ Testing commit dd8d0d578af62fbfc95b29ee8000c03cf746a1aa with merge 362832fdaa4344af59685f74fbf1bdb9704300c3... |
It does respect rust/src/test/rustdoc-ui/cfg-test.rs Line 2 in 9fe551a
Will that not work here? |
@bors retry r- Let's try the test-threads=1 solution. |
I changed this to use @ollie27's suggestion. |
I'm not sure that this will help, but it certainly won't hurt, and I can always split up the tests in a later PR. |
This is causing further failures (#76297 (comment)) ... @Mark-Simulacrum, @ollie27 could one of you review this? |
@bors r=Mark-Simulacrum,ollie27 |
📌 Commit ed4dcc0 has been approved by |
@bors p=1 Causing spurious failures |
⌛ Testing commit ed4dcc0 with merge 178018f921b5c02381a1169fe3ebed912494609c... |
Is there an issue open to track fixing the underlying non-determinism? |
I'm not sure it should be considered a bug. If you run |
💥 Test timed out |
@bors retry |
☀️ Test successful - checks-actions, checks-azure |
Closes #76442 (hopefully, since it's non-deterministic I don't have a way to test).
r? @Mark-Simulacrum
cc @GuillaumeGomez