-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Some cleanup changes and commenting #76641
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
96d770d
to
ff5c5a6
Compare
Seems like we forgot about nonsensical bounds in nonsensical code.
That test does |
I'll change that commit to be adding a comment explaining why we can't fast-path types that are trivially |
ff5c5a6
to
caf6c92
Compare
is_sized
and drive-by improve a few things
I added a comment on |
I want @nikomatsakis to see this (I forgot about trivial bounds too!), but also, we can: @bors rollup |
@bors r=eddyb rollup |
📌 Commit caf6c92 has been approved by |
Some cleanup changes and commenting r? @nikomatsakis Cc @eddyb
Some cleanup changes and commenting r? @nikomatsakis Cc @eddyb
Some cleanup changes and commenting r? @nikomatsakis Cc @eddyb
Some cleanup changes and commenting r? @nikomatsakis Cc @eddyb
Some cleanup changes and commenting r? @nikomatsakis Cc @eddyb
Rollup of 10 pull requests Successful merges: - rust-lang#76056 (Add more info for Vec Drain doc) - rust-lang#76062 (Vec slice example fix style and show type elision) - rust-lang#76262 (Use inline(never) instead of cold) - rust-lang#76335 (Make all methods of `Duration` unstably const) - rust-lang#76366 (Add Arith Tests in Library) - rust-lang#76369 (Move Various str tests in library) - rust-lang#76534 (Add doc comments for From impls) - rust-lang#76622 (Update bootstrap readme) - rust-lang#76641 (Some cleanup changes and commenting) - rust-lang#76662 (Fix liballoc test suite for Miri) Failed merges: r? `@ghost`
r? @nikomatsakis
Cc @eddyb