Use intra-doc links in core/src/iter when possible #76867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-intra-doc-links
rust-highfive
added
the
S-waiting-on-review
jyn514
reviewed
Sep 18, 2020
|
@poliorcetics I have a patch for sources too #76816 but I was inclined to move them to |
jyn514
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
rustbot
added
S-waiting-on-review
|
@bors r+ rollup It would be nice to move from 'the function f' to 'f()' at some point, but that doesn't need to block this PR. |
|
📌 Commit 08b85a6 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 21, 2020
…=jyn514 Use intra-doc links in core/src/iter when possible Helps with rust-lang#75080. I also updated lots of links to use `fn()` instead of `fn` when possible. @rustbot modify labels: T-doc A-intra-doc-links r? @jyn514
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 21, 2020
…=jyn514 Use intra-doc links in core/src/iter when possible Helps with rust-lang#75080. I also updated lots of links to use `fn()` instead of `fn` when possible. @rustbot modify labels: T-doc A-intra-doc-links r? @jyn514
pickfire
reviewed
Sep 21, 2020
| @@ -393,10 +379,8 @@ pub fn once<T>(value: T) -> Once<T> { | |||
| /// An iterator that yields a single element of type `A` by | |||
| /// applying the provided closure `F: FnOnce() -> A`. | |||
| /// | |||
| /// This `struct` is created by the [`once_with`] function. | |||
| /// This `struct` is created by the [`once_with()`] function. | |||
There was a problem hiding this comment.
Suggested change
| /// This `struct` is created by the [`once_with()`] function. | |
| /// This `struct` is created by [`iter::once_with()`]. |
Based on #76816 comments
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Sep 21, 2020
…=jyn514 Use intra-doc links in core/src/iter when possible Helps with rust-lang#75080. I also updated lots of links to use `fn()` instead of `fn` when possible. @rustbot modify labels: T-doc A-intra-doc-links r? @jyn514
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 21, 2020
Rollup of 13 pull requests Successful merges: - rust-lang#76135 (Stabilize some Option methods as const) - rust-lang#76628 (Add sample defaults for config.toml ) - rust-lang#76846 (Avoiding unnecesary allocations at rustc_errors) - rust-lang#76867 (Use intra-doc links in core/src/iter when possible) - rust-lang#76868 (Finish moving to intra doc links for std::sync) - rust-lang#76872 (Remove DeclareMethods) - rust-lang#76936 (Add non-`unsafe` `.get_mut()` for `Unsafecell`) - rust-lang#76958 (Replace manual as_nanos and as_secs_f64 reimplementations) - rust-lang#76959 (Replace write_fmt with write!) - rust-lang#76961 (Add test for issue rust-lang#34634) - rust-lang#76962 (Use const_cstr macro in consts.rs) - rust-lang#76963 (Remove unused static_assert macro) - rust-lang#77000 (update Miri) Failed merges: r? `@ghost`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with #75080.
I also updated lots of links to use
fn()instead offnwhen possible.@rustbot modify labels: T-doc A-intra-doc-links
r? @jyn514