Rollup of 15 pull requests #76937

RalfJung · 2020-09-19T20:20:58Z

Successful merges:

Fix segfault if pthread_getattr_np fails #76521 (Fix segfault if pthread_getattr_np fails)
Test and fix Send and Sync traits of BTreeMap artefacts #76722 (Test and fix Send and Sync traits of BTreeMap artefacts)
Don't generate bootstrap usage unless it's needed #76800 (Don't generate bootstrap usage unless it's needed)
simplfy condition in ItemLowerer::with_trait_impl_ref() #76809 (simplfy condition in ItemLowerer::with_trait_impl_ref())
Fix wording in mir doc #76815 (Fix wording in mir doc)
Don't compile regex at every function call. #76818 (Don't compile regex at every function call.)
Remove redundant nightly features #76821 (Remove redundant nightly features)
black_box: silence unused_mut warning when building with cfg(miri) #76823 (black_box: silence unused_mut warning when building with cfg(miri))
use array_windows instead of windows in the compiler #76825 (use array_windows instead of windows in the compiler)
fix array_windows docs #76827 (fix array_windows docs)
use strip_prefix over starts_with and manual slicing based on pattern length (clippy::manual_strip) #76828 (use strip_prefix over starts_with and manual slicing based on pattern length (clippy::manual_strip))
Move to intra doc links in core/src/future #76840 (Move to intra doc links in core/src/future)
Use intra docs links in core::{ascii, option, str, pattern, hash::map} #76845 (Use intra docs links in core::{ascii, option, str, pattern, hash::map})
Use intra-doc links in library/core/src/task/wake.rs #76853 (Use intra-doc links in library/core/src/task/wake.rs)
Remove unused feature gates from library/ crates #76866 (Remove unused feature gates from library/ crates)

Failed merges:

glibc destroys[1] the passed pthread_attr_t if pthread_getattr_np() fails. Destroying it again leads to a segfault. Fix it by only destroying it on success for glibc. [1]: https://sourceware.org/git/?p=glibc.git;a=blob;f=nptl/pthread_getattr_np.c;h=ce437205e41dc05653e435f6188768cccdd91c99;hb=HEAD#l205

…ibcs The calling convention of pthread_getattr_np() is to initialize the pthread_attr_t, so _destroy() is only necessary on success (and _init() isn't necessary beforehand). On the other hand, FreeBSD wants the attr_t to be initialized before pthread_attr_get_np(), and therefore it should always be destroyed afterwards.

Previously, `x.py` would unconditionally run `x.py build` to get the help message. After rust-lang#76165, when checking the CI stage was moved into `Config`, that would cause an assertion failure (but only only in CI!): ``` thread 'main' panicked at 'assertion failed: `(left == right)` left: `1`, right: `2`', src/bootstrap/config.rs:619:49 ``` This changes bootstrap to only generate a help message when it needs to (when someone passes `--help`).

Use `SyncOnceCell` to only compile it once. I believe this still adds some kind of locking mechanism?

The use of arith_offset was added in 803e9ae before the stable wrapper of the intrinsic was available. https://doc.rust-lang.org/stable/std/intrinsics/fn.arith_offset.html

The latter is on the path to stabilization.

… length (clippy::manual_strip)

Co-authored-by: est31 <est31@users.noreply.github.com>

Libc isn't used by alloc. And std and panic_* use libc from crates.io now, which isn't feature gated.

Co-authored-by: Joshua Nelson <joshua@yottadb.com>

…roy, r=Amanieu Fix segfault if pthread_getattr_np fails glibc [destroys][1] the passed pthread_attr_t if pthread_getattr_np() fails. Destroying it again leads to a segfault. Fix it by only destroying it on success for glibc. [1]: https://sourceware.org/git/?p=glibc.git;a=blob;f=nptl/pthread_getattr_np.c;h=ce437205e41dc05653e435f6188768cccdd91c99;hb=HEAD#l205

@Mark-Simulacrum

…ulacrum Test and fix Send and Sync traits of BTreeMap artefacts Fixes rust-lang#76686. I'm not quite sure what all this implies. E.g. comparing with the definitions for `NodeRef` in node.rs, maybe an extra bound `T: 'a` is useful for something. The test compiles on stable/beta (apart from `drain_filter`) so I bet `Sync` is equally desirable. r? @Mark-Simulacrum

@Mark-Simulacrum

Don't generate bootstrap usage unless it's needed Previously, `x.py` would unconditionally run `x.py build` to get the help message. After rust-lang#76165, when checking the CI stage was moved into `Config`, that would cause an assertion failure (but only only in CI!): ``` thread 'main' panicked at 'assertion failed: `(left == right)` left: `1`, right: `2`', src/bootstrap/config.rs:619:49 ``` This changes bootstrap to only generate a help message when it needs to (when someone passes `--help`). r? @Mark-Simulacrum This should fix the CI failures in rust-lang#76797 and rust-lang#75991.

simplfy condition in ItemLowerer::with_trait_impl_ref()

Fix wording in mir doc

…me, r=ecstatic-morse Don't compile regex at every function call. Use `SyncOnceCell` to only compile it once. I believe this still adds some kind of locking mechanism? Related issue: rust-lang#76817

…ures, r=oli-obk,Mark-Simulacrum Remove redundant nightly features Removes a bunch of redundant/outdated nightly features. The first commit removes a `core_intrinsics` use for which a stable wrapper has been provided since. The second commit replaces the `const_generics` feature with `min_const_generics` which might get stabilized this year. The third commit is the result of a trial/error run of removing every single feature and then adding it back if compile failed. A bunch of unused features are the result that the third commit removes.

…lett black_box: silence unused_mut warning when building with cfg(miri)

use `array_windows` instead of `windows` in the compiler I do think these changes are beautiful, but do have to admit that using type inference for the window length can easily be confusing. This seems like a general issue with const generics, where inferring constants adds an additional complexity which users have to learn and keep in mind.

@Dylan-DPC

…hievink fix array_windows docs r? @Dylan-DPC

…=lcnr use strip_prefix over starts_with and manual slicing based on pattern length (clippy::manual_strip)

@rustbot

…d-future, r=jyn514 Move to intra doc links in core/src/future Helps with rust-lang#75080. @rustbot modify labels: T-doc A-intra-doc-links r? @jyn514

@rustbot

Use intra docs links in core::{ascii, option, str, pattern, hash::map} Partial fix for rust-lang#75080 @rustbot modify labels: T-doc A-intra-doc-links r? @jyn514

@rustbot

…ake, r=jyn514 Use intra-doc links in library/core/src/task/wake.rs Helps with rust-lang#75080. @rustbot modify labels: T-doc, A-intra-doc-links

Remove unused feature gates from library/ crates Removes some unused feature gates from library crates. It's likely not a complete list as I only tested a subset for which it's more likely that it is unused.

RalfJung · 2020-09-19T20:21:56Z

@rustbot modify labels: +rollup
@bors r+ rollup=never p=15

bors · 2020-09-19T20:21:57Z

📌 Commit 771fdde has been approved by RalfJung

bors · 2020-09-19T21:56:04Z

⌛ Testing commit 771fdde with merge 5dbc50315c6fe0820a9a1d882f5a250e43de1cb4...

bors · 2020-09-19T22:07:54Z

💔 Test failed - checks-azure

tavianator and others added 30 commits September 9, 2020 10:21

Test and fix Sync & Send traits of BTreeMap artefacts

176956c

simplfy condition in ItemLowerer::with_trait_impl_ref()

94dae60

Fix wording in mir doc

b7c8bea

Don't compile regex at every function call.

f4a7149

Use `SyncOnceCell` to only compile it once. I believe this still adds some kind of locking mechanism?

Remove intrinsics::arith_offset use from libarena

b479139

The use of arith_offset was added in 803e9ae before the stable wrapper of the intrinsic was available. https://doc.rust-lang.org/stable/std/intrinsics/fn.arith_offset.html

Replace const_generics feature gate with min_const_generics

4fe6ca3

The latter is on the path to stabilization.

Remove redundant #![feature(...)] 's from compiler/

ebdea01

fix array_windows docs

5f58e00

use array_windows instead of windows in the compiler

2793672

array pattern

f193593

use strip_prefix over starts_with and manual slicing based on pattern…

012974d

… length (clippy::manual_strip)

docs array -> slice

764d307

Co-authored-by: est31 <est31@users.noreply.github.com>

black_box: silence unused_mut warning when building with cfg(miri)

1dd3df6

Move to intra doc links in core/src/future

76ec3f8

Use intra-doc links

8e9ad31

Fixed some intra-docs links in library/core

3323a26

Fixed intra-docs links in library/std/src/collections/hash/map.rs

878dfa6

Remove unused libc feature gate

baafc71

Libc isn't used by alloc. And std and panic_* use libc from crates.io now, which isn't feature gated.

Apply suggestions from code review

4c92b3d

Co-authored-by: Joshua Nelson <joshua@yottadb.com>

Remove some unused features from alloc core and std

f272896

Rollup merge of rust-lang#76809 - matthiaskrgr:simplify_cond, r=varkor

511a6b0

simplfy condition in ItemLowerer::with_trait_impl_ref()

Rollup merge of rust-lang#76815 - pickfire:patch-6, r=jonas-schievink

c4eb073

Fix wording in mir doc

Rollup merge of rust-lang#76818 - hbina:dont_compile_regex_all_the_ti…

682770b

…me, r=ecstatic-morse Don't compile regex at every function call. Use `SyncOnceCell` to only compile it once. I believe this still adds some kind of locking mechanism? Related issue: rust-lang#76817

RalfJung added 8 commits September 19, 2020 22:20

Rollup merge of rust-lang#76823 - RalfJung:black-box-warn, r=joshtrip…

c9859bb

…lett black_box: silence unused_mut warning when building with cfg(miri)

Rollup merge of rust-lang#76827 - lcnr:array_windows-docs, r=jonas-sc…

fff2344

…hievink fix array_windows docs r? @Dylan-DPC

Rollup merge of rust-lang#76828 - matthiaskrgr:clippy_manual_strip, r…

b396bfe

…=lcnr use strip_prefix over starts_with and manual slicing based on pattern length (clippy::manual_strip)

Rollup merge of rust-lang#76840 - poliorcetics:intra-doc-core-sync-an…

dec4ddc

…d-future, r=jyn514 Move to intra doc links in core/src/future Helps with rust-lang#75080. @rustbot modify labels: T-doc A-intra-doc-links r? @jyn514

Rollup merge of rust-lang#76845 - Amjad50:fix-intra-docs-links, r=jyn514

7c1623b

Use intra docs links in core::{ascii, option, str, pattern, hash::map} Partial fix for rust-lang#75080 @rustbot modify labels: T-doc A-intra-doc-links r? @jyn514

Rollup merge of rust-lang#76853 - denisvasilik:intra-doc-links-core-w…

5518cc9

…ake, r=jyn514 Use intra-doc links in library/core/src/task/wake.rs Helps with rust-lang#75080. @rustbot modify labels: T-doc, A-intra-doc-links

Rollup merge of rust-lang#76866 - est31:master, r=lcnr

771fdde

Remove unused feature gates from library/ crates Removes some unused feature gates from library crates. It's likely not a complete list as I only tested a subset for which it's more likely that it is unused.

rustbot added the rollup A PR which is a rollup label Sep 19, 2020

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 19, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 19, 2020

RalfJung closed this Sep 19, 2020

RalfJung deleted the rollup-jjvtux5 branch September 20, 2020 00:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 15 pull requests #76937

Rollup of 15 pull requests #76937

Uh oh!

RalfJung commented Sep 19, 2020

Uh oh!

RalfJung commented Sep 19, 2020

Uh oh!

bors commented Sep 19, 2020

Uh oh!

bors commented Sep 19, 2020

Uh oh!

bors commented Sep 19, 2020

Uh oh!

Uh oh!

Rollup of 15 pull requests #76937

Rollup of 15 pull requests #76937

Uh oh!

Conversation

RalfJung commented Sep 19, 2020

Uh oh!

RalfJung commented Sep 19, 2020

Uh oh!

bors commented Sep 19, 2020

Uh oh!

bors commented Sep 19, 2020

Uh oh!

bors commented Sep 19, 2020

Uh oh!

Uh oh!