Skip to content

Enable building Cargo for aarch64-apple-darwin #77239

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 14, 2020
Merged

Enable building Cargo for aarch64-apple-darwin #77239

merged 4 commits into from
Oct 14, 2020

Conversation

shepmaster
Copy link
Member

r? @ghost

@shepmaster

This comment has been minimized.

# to view
@bors

This comment has been minimized.

# to view
@shepmaster

This comment has been minimized.

# to view
@bors

This comment has been minimized.

# to view
@rust-log-analyzer

This comment has been minimized.

# to view
@bors
Copy link
Collaborator

bors commented Sep 26, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: ac7767935cf615cd80216919f4e2c62ea765d9ed (ac7767935cf615cd80216919f4e2c62ea765d9ed)

@shepmaster
Copy link
Member Author

@pietroalbini how would you feel about me submitting e51b507 and ddb8ed2 as a separate PR? TL;DR: they move the try job below all the other ones so that we can use a YAML anchor instead of copy-pasta the builder specs when we want to change what platforms are built by try. This is immensely helpful when trying anything besides the default x86-64 linux builds, which only take a few lines of config, compared to e.g. the macOS builders which are much more.

@shepmaster shepmaster mentioned this pull request Sep 27, 2020
Merged
@shepmaster

This comment has been minimized.

# to view
@bors

This comment has been minimized.

# to view
@bors
Copy link
Collaborator

bors commented Sep 27, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: 9fa745e4c5f16139c128992e21a3f10a7589948d (9fa745e4c5f16139c128992e21a3f10a7589948d)

@pietroalbini
Copy link
Member

@pietroalbini how would you feel about me submitting e51b507 and ddb8ed2 as a separate PR? TL;DR: they move the try job below all the other ones so that we can use a YAML anchor instead of copy-pasta the builder specs when we want to change what platforms are built by try. This is immensely helpful when trying anything besides the default x86-64 linux builds, which only take a few lines of config, compared to e.g. the macOS builders which are much more.

Sounds good!

@bors

This comment has been minimized.

# to view
@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 1, 2020
@shepmaster shepmaster force-pushed the silicon-ci-plus branch 2 times, most recently from 2a8bd11 to 966b398 Compare October 4, 2020 19:14
@shepmaster

This comment has been minimized.

# to view
@bors

This comment has been minimized.

# to view
@bors
Copy link
Collaborator

bors commented Oct 4, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: edb89086d353eb63b40774691d1025a9d073df03 (edb89086d353eb63b40774691d1025a9d073df03)

@shepmaster

This comment has been minimized.

# to view
@bors

This comment has been minimized.

# to view
@bors
Copy link
Collaborator

bors commented Oct 12, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: bef4c2e0681c0c80fa79543d1c1e092cde44d838 (bef4c2e0681c0c80fa79543d1c1e092cde44d838)

@shepmaster shepmaster changed the title Next steps on Silicon CI Enable building Cargo for aarch64-apple-darwin Oct 12, 2020
@shepmaster
Copy link
Member Author

r? @pietroalbini

/cc @Mark-Simulacrum

@shepmaster shepmaster marked this pull request as ready for review October 12, 2020 20:33
@pietroalbini
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 13, 2020

📌 Commit eb0c996 has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 13, 2020
@shepmaster
Copy link
Member Author

@bors r=@pietroalbini

@bors
Copy link
Collaborator

bors commented Oct 13, 2020

📌 Commit 8b6e346 has been approved by pietroalbini

@bors
Copy link
Collaborator

bors commented Oct 13, 2020

⌛ Testing commit 8b6e346 with merge f715f43d4d1e850ef807de9f4c08de4e5e1517cc...

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 13, 2020
@JohnTitor
Rollup merge of rust-lang#77239 - shepmaster:silicon-ci-plus, r=pietr…
ccd3914 
…oalbini

Enable building Cargo for aarch64-apple-darwin

r? @ghost
@JohnTitor JohnTitor mentioned this pull request Oct 13, 2020
Closed
@JohnTitor
Copy link
Member

@bors retry yielding

@JohnTitor JohnTitor mentioned this pull request Oct 13, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 13, 2020
@bors
Auto merge of rust-lang#77917 - JohnTitor:rollup-e47h2qt, r=JohnTitor
f243a2a 
Rollup of 14 pull requests

Successful merges:

 - rust-lang#77239 (Enable building Cargo for aarch64-apple-darwin)
 - rust-lang#77569 (BTreeMap: type-specific variants of node_as_mut and cast_unchecked)
 - rust-lang#77719 (Remove unnecessary rustc_const_stable attributes.)
 - rust-lang#77722 (Remove unsafety from sys/unsupported and add deny(unsafe_op_in_unsafe_fn).)
 - rust-lang#77725 (Add regression issue template)
 - rust-lang#77776 ( Give an error when running `x.py test --stage 0 src/test/ui`)
 - rust-lang#77786 (Mention rustdoc in `x.py setup`)
 - rust-lang#77825 (`min_const_generics` diagnostics improvements)
 - rust-lang#77868 (Include `llvm-dis`, `llc` and `opt` in `llvm-tools-preview` component)
 - rust-lang#77884 (Use Option::unwrap_or instead of open-coding it)
 - rust-lang#77886 (Replace trivial bool matches with the `matches!` macro)
 - rust-lang#77892 (Replace absolute paths with relative ones)
 - rust-lang#77895 (Include aarch64-apple-darwin in the dist manifests)
 - rust-lang#77909 (bootstrap: set correct path for the build-manifest binary)

Failed merges:

 - rust-lang#77902 (Include aarch64-pc-windows-msvc in the dist manifests)

r? `@ghost`
@bors bors merged commit 16612a9 into rust-lang:master Oct 14, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 14, 2020
@shepmaster shepmaster deleted the silicon-ci-plus branch October 14, 2020 00:38
@shepmaster shepmaster mentioned this pull request Oct 14, 2020
Closed
31 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@pietroalbini pietroalbini

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
6 participants
@shepmaster @bors @rust-log-analyzer @pietroalbini @JohnTitor @rustbot