Skip to content

Stabilize Option::unwrap_none and Option::expect_none #77326

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Stabilize Option::unwrap_none and Option::expect_none #77326

wants to merge 1 commit into from

Conversation

Aaron1011
Copy link
Member

cc #62633

These methods have been on nightly for over a year without any issues.

@rust-highfive
Copy link
Contributor

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 29, 2020
@Aaron1011
Stabilize Option::unwrap_none and Option::expect_none
5a6df49 
cc rust-lang#62633

These methods have been on nightly for over a year without any issues.
@Aaron1011 Aaron1011 force-pushed the stabilize-option-none branch from efa48b5 to 5a6df49 Compare September 29, 2020 05:28
@jyn514 jyn514 added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Sep 29, 2020
@jonas-schievink jonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 29, 2020
@cuviper
Copy link
Member

cuviper commented Sep 30, 2020

I'm in favor, but there was some debate in #73077.

@Aaron1011
Copy link
Member Author

I somehow missed that other PR when I read through the tracking issue.

@scottmcm scottmcm added the needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. label Oct 2, 2020
@LeSeulArtichaut LeSeulArtichaut added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2020
@crlf0710 crlf0710 added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Nov 6, 2020
@crlf0710 crlf0710 added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Nov 28, 2020
@poliorcetics
Copy link
Contributor

I really don’t like those methods over assert(_...)! macros. Maybe I just never encountered the cases when this becomes heavy to write but those methods just look like bloat to me.

@crlf0710 crlf0710 added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Dec 18, 2020
@crlf0710 crlf0710 added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Jan 15, 2021
@bors
Copy link
Collaborator

bors commented Jan 26, 2021

☔ The latest upstream changes (presumably #81417) made this pull request unmergeable. Please resolve the merge conflicts.

@m-ou-se
Copy link
Member

m-ou-se commented Feb 17, 2021

Closing this because of #62633 (comment).

(Not closing the tracking issue yet. More discussion is still welcome there.

@m-ou-se m-ou-se closed this Feb 17, 2021
@trevyn trevyn mentioned this pull request Feb 22, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@sfackler sfackler

Labels
needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.