Skip to content

BTreeMap/Set: complete the compile-time test cases #77445

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 4, 2020

Conversation

ssomers
Copy link
Contributor

@ssomers ssomers commented Oct 2, 2020

Some of the items added to the new test_sync belonged in the old test_variance as well. And fixed inconsistent paths to nearby modules.
r? @Mark-Simulacrum

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 2, 2020
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 3, 2020

📌 Commit e87d391 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2020
@ssomers
Copy link
Contributor Author

ssomers commented Oct 3, 2020

Oops, did not notice the rollup... but it failed anyway.

I noticed I missed the third compile-time test case, while figuring out the same thing in BTreeSet, so now that's all in here.

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 4, 2020

📌 Commit a58089e has been approved by Mark-Simulacrum

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 4, 2020
…as-schievink

Rollup of 8 pull requests

Successful merges:

 - rust-lang#77072 (Minor `hash_map` doc adjustments + item attribute orderings)
 - rust-lang#77368 (Backport LLVM apfloat commit to rustc_apfloat)
 - rust-lang#77445 (BTreeMap: complete the compile-time test_variance test case)
 - rust-lang#77504 (Support vectors with fewer than 8 elements for simd_select_bitmask)
 - rust-lang#77513 (Change DocFragments from enum variant fields to structs with a nested enum)
 - rust-lang#77518 (Only use Fira Sans for the first `td` in item lists)
 - rust-lang#77521 (Move target feature whitelist from cg_llvm to cg_ssa)
 - rust-lang#77525 (Enable RenameReturnPlace MIR optimization on mir-opt-level >= 2)

Failed merges:

r? `@ghost`
@ssomers ssomers changed the title BTreeMap: complete the compile-time test_variance test case BTreeMap/Set: complete the compile-time test cases Oct 4, 2020
@bors bors merged commit 8095317 into rust-lang:master Oct 4, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 4, 2020
@ssomers ssomers deleted the btree_cleanup_7 branch October 4, 2020 16:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants