Skip to content

Remove redundant backslashes from lldb_commands #77609

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

artemmukhin
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 6, 2020
@Mark-Simulacrum
Copy link
Member

Do you have some way of confirming this doesn't break anything? I'm a bit worried that they will not be redundant somewhere (e.g., on a prior version)... I don't know that we have tests for this file, either.

If they're harmless I am inclined to leave them in.

@artemmukhin
Copy link
Contributor Author

@Mark-Simulacrum The current version of rust-lldb (and so the script shipped with rust 1.47) doesn't use appropriate pretty-printers because of these backslashes, at least on my machine (macOS 10.15.6, with lldb-1200.0.32.1). But with this patch, rust-lldb works fine. So this PR is not just a cleanup, but a bug-fix. Actually, these backslashes were added accidentally when I converted LLDB command-line arguments to lldb_commands file.

It would be great if someone else tests it. And there really should be some tests for rust-lldb with different LLDB versions.

@Mark-Simulacrum
Copy link
Member

Ok, given that they were recently added seems fine to remove.

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Oct 9, 2020

📌 Commit 4f792d6 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2020
@bors
Copy link
Collaborator

bors commented Oct 9, 2020

⌛ Testing commit 4f792d6 with merge be719d1...

@bors
Copy link
Collaborator

bors commented Oct 9, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing be719d1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 9, 2020
@bors bors merged commit be719d1 into rust-lang:master Oct 9, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 9, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants