Add compile fail test for issue 27675 #77663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Aaron1011 as highfive didn't set a reviewer and you commented on that issue. |
JohnTitor
added
the
S-waiting-on-review
Aaron1011
reviewed
Oct 7, 2020
HeroicKatora
force-pushed
the
regression-tests-27675-object-safe
branch
from
8a44ce1 to
ea206f2
Compare
|
@bors r+ |
|
📌 Commit ea206f2 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Oct 8, 2020
…-object-safe, r=Aaron1011 Add compile fail test for issue 27675 A recently merged PR (rust-lang#73905) strengthened the checks on bounds of associated items. This rejects the attack path of rust-lang#27675 which consisted of constructing a `dyn Trait<Item=T>` where `T` would not fulfill the bounds required on `Item` of the `Trait` behind the dyn object. This regression test, extracted from [the weaponized instance](rust-lang#27675 (comment)), checks that this is rejected.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 8, 2020
…as-schievink Rollup of 8 pull requests Successful merges: - rust-lang#76750 (Don't discourage implementing `core::fmt::Write`) - rust-lang#77449 (BTreeMap: comment why drain_filter's size_hint is somewhat pessimistic) - rust-lang#77660 ((docs): make mutex error comment consistent with codebase) - rust-lang#77663 (Add compile fail test for issue 27675) - rust-lang#77673 (Remove unnecessary lamda on emitter map.) - rust-lang#77701 (Make `max_log_info` easily greppable (for figuring out why debug logging is disabled)) - rust-lang#77702 (Remove not needed lambda.) - rust-lang#77710 (Update submodule llvm to get LVI bugfix) Failed merges: r? `@ghost`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recently merged PR (#73905) strengthened the checks on bounds of associated items. This rejects the attack path of #27675 which consisted of constructing a
dyn Trait<Item=T>whereTwould not fulfill the bounds required onItemof theTraitbehind the dyn object.This regression test, extracted from the weaponized instance, checks that this is rejected.