Skip to content

Clean up small, surprising bits of code #78066

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 6 commits into from
Oct 18, 2020
Merged

Clean up small, surprising bits of code #78066

merged 6 commits into from
Oct 18, 2020

Conversation

bugadani
Copy link
Contributor

This PR clean up a small number of unrelated, small things I found while browsing the code base.

@rust-highfive
Copy link
Contributor

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2020
Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jonas-schievink
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 18, 2020

📌 Commit 2e99439 has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2020
@bors
Copy link
Collaborator

bors commented Oct 18, 2020

⌛ Testing commit 2e99439 with merge 834821e...

Copy link
Member

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@frewsxcv
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 18, 2020

@frewsxcv: 🔑 Insufficient privileges: Not in reviewers

@frewsxcv
Copy link
Member

first time i've attempted to approve a pr in a while, guess i lost privileges 😅

@frewsxcv
Copy link
Member

oh and looks like it was already approved, oops

@bors
Copy link
Collaborator

bors commented Oct 18, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: jonas-schievink
Pushing 834821e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 18, 2020
@bors bors merged commit 834821e into rust-lang:master Oct 18, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 18, 2020
@bugadani bugadani deleted the wat branch October 18, 2020 16:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants