Skip to content

Disable "optimization to avoid load of address" in InstCombine #78195

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Oct 21, 2020

The transformation is incorrect #78192. Disable it.

@rust-highfive
Copy link
Contributor

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 21, 2020
@jonas-schievink
Copy link
Contributor

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Oct 21, 2020

📌 Commit e200a4a has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2020
@jonas-schievink jonas-schievink added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 21, 2020
@bors
Copy link
Collaborator

bors commented Oct 21, 2020

⌛ Testing commit e200a4a with merge 1d27267...

@bors
Copy link
Collaborator

bors commented Oct 21, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: jonas-schievink
Pushing 1d27267 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 21, 2020
@bors bors merged commit 1d27267 into rust-lang:master Oct 21, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 21, 2020
@tmiasko tmiasko deleted the instcombine branch October 21, 2020 19:55
@camelid camelid added the A-mir-opt Area: MIR optimizations label Oct 21, 2020
@spastorino
Copy link
Member

discussed in T-compiler meeting.

@rustbot modify labels: beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 22, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 27, 2020
…leywiser

Disable "optimization to avoid load of address" in InstCombine

Same as rust-lang#78195, fixes rust-lang#78192 (again).
@jonas-schievink jonas-schievink mentioned this pull request Oct 28, 2020
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 5, 2020
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.49.0, 1.48.0 Nov 5, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 7, 2020
…ulacrum

[beta] backports

This backports a number of PRs to beta:

* Add delay_span_bug to no longer ICE rust-lang#78645
* Do not ICE on invalid input rust-lang#78422
* revert rust-lang#75443, update mir validator rust-lang#78410
* Do not try to report on closures to avoid ICE rust-lang#78268
* Disable "optimization to avoid load of address" in InstCombine rust-lang#78195
* Disable MatchBranchSimplification rust-lang#78151
* Do not ICE with TraitPredicates containing [type error] rust-lang#77930
* Tweak `if let` suggestion to be more liberal with suggestion and to not ICE rust-lang#77283
* Use different mirror for linux headers in musl-toolchain CI script. rust-lang#78316
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-mir-opt Area: MIR optimizations beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants