Skip to content

Stabilize refcell_take #78608

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2020
Merged

Stabilize refcell_take #78608

merged 1 commit into from
Nov 23, 2020

Conversation

ThinkChaos
Copy link
Contributor

Tracking Issue: #71395

@KodrAus nominated this for FCP, so here's a PR!
I've never made a stabilization PR, so please mention if there's anything I can improve, thanks.

@rust-highfive
Copy link
Contributor

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 31, 2020
@m-ou-se
Copy link
Member

m-ou-se commented Nov 1, 2020

r? @KodrAus for FCP

@rust-highfive rust-highfive assigned KodrAus and unassigned cramertj Nov 1, 2020
@m-ou-se m-ou-se added needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Nov 1, 2020
@m-ou-se
Copy link
Member

m-ou-se commented Nov 9, 2020

r? @m-ou-se for FCP :)

@rfcbot fcp merge

@rfcbot
Copy link
Collaborator

rfcbot commented Nov 9, 2020 •
edited by KodrAus
Loading

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Nov 9, 2020
@rfcbot rfcbot added disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Nov 9, 2020
@rfcbot
Copy link
Collaborator

rfcbot commented Nov 12, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

m-ou-se
m-ou-se reviewed Nov 13, 2020
View reviewed changes
@ThinkChaos ThinkChaos force-pushed the stabilize_refcell_take branch from 0ff995e to 37199dd Compare November 15, 2020 17:07
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Nov 22, 2020
@rfcbot
Copy link
Collaborator

rfcbot commented Nov 22, 2020

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@dtolnay
Copy link
Member

dtolnay commented Nov 22, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 22, 2020

📌 Commit 37199dd51e42896ca39febfb9748665208558509 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2020
@bors
Copy link
Collaborator

bors commented Nov 22, 2020

⌛ Testing commit 37199dd51e42896ca39febfb9748665208558509 with merge 4ddfa466b78236835e9cb598caccb3e6b79a6183...

@bors
Copy link
Collaborator

bors commented Nov 22, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 22, 2020
@m-ou-se
Copy link
Member

m-ou-se commented Nov 22, 2020

Looks like in the meantime a #![feature(refcell_take)] got added to std's lib.rs on the main branch, causing the merged result to fail.

@ThinkChaos ThinkChaos force-pushed the stabilize_refcell_take branch from 37199dd to ca60a15 Compare November 22, 2020 19:04
@ThinkChaos ThinkChaos force-pushed the stabilize_refcell_take branch from ca60a15 to 5c6689b Compare November 22, 2020 19:16
@m-ou-se
Copy link
Member

m-ou-se commented Nov 22, 2020

Thanks @ThinkChaos!

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 22, 2020

📌 Commit 5c6689b has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2020
@ThinkChaos
Copy link
Contributor Author

Thank you all, especially @m-ou-se, you've been really helpful and responsive!

m-ou-se added a commit to m-ou-se/rust that referenced this pull request Nov 22, 2020
@m-ou-se
Rollup merge of rust-lang#78608 - ThinkChaos:stabilize_refcell_take, …
31a2768 
…r=m-ou-se

Stabilize refcell_take

Tracking Issue: rust-lang#71395

`@KodrAus` nominated this for FCP, so here's a PR!
I've never made a stabilization PR, so please mention if there's anything I can improve, thanks.
@m-ou-se m-ou-se mentioned this pull request Nov 22, 2020
Closed
@m-ou-se m-ou-se mentioned this pull request Nov 22, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 22, 2020
@bors
Auto merge of rust-lang#79319 - m-ou-se:rollup-d9n5viq, r=m-ou-se
32da90b 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#76941 (Add f{32,64}::is_subnormal)
 - rust-lang#77697 (Split each iterator adapter and source into individual modules)
 - rust-lang#78305 (Stabilize alloc::Layout const functions)
 - rust-lang#78608 (Stabilize refcell_take)
 - rust-lang#78793 (Clean up `StructuralEq` docs)
 - rust-lang#79267 (BTreeMap: address namespace conflicts)
 - rust-lang#79293 (Add test for eval order for a+=b)
 - rust-lang#79295 (BTreeMap: fix minor testing mistakes in rust-lang#78903)
 - rust-lang#79297 (BTreeMap: swap the names of NodeRef::new and Root::new_leaf)
 - rust-lang#79299 (Stabilise `then`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b249844 into rust-lang:master Nov 23, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 23, 2020
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Dec 3, 2020
@pthariensflame
Copy link
Contributor

relnotes needed?

@ThinkChaos
Copy link
Contributor Author

Just a mention in stabilized APIs would be nice, thanks!

@pthariensflame
Copy link
Contributor

@m-ou-se Any chance of putting that label on?

@m-ou-se m-ou-se added the relnotes Marks issues that should be documented in the release notes of the next release. label Jan 2, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Jan 2, 2021

Maybe rfcbot could add relnotes when the FCP on a PR ends. Just like it already does for a few other labels:

image

@pthariensflame
Copy link
Contributor

pthariensflame commented Jan 2, 2021 •
edited
Loading

That seems like a good idea! Although not all PRs would apply.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@m-ou-se m-ou-se m-ou-se left review comments

@dtolnay dtolnay dtolnay approved these changes

Assignees

@m-ou-se m-ou-se

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.