Skip to content

Suggest library/std when running all stage 0 tests #78687

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Nov 2, 2020

r? @Mark-Simulacrum
cc @ijackson

For context, this came out of a discord conversation where @ijackson was running test --stage 1 when they were only adding doc-tests to the standard library.

@jyn514 jyn514 added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust labels Nov 2, 2020
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 2, 2020
@Mark-Simulacrum
Copy link
Member

I will note that testing the standard library will not have full coverage in stage 0, but since it is rare to be adding bootstrap-dependent bits this seems fine to me.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 3, 2020

📌 Commit 1aedcd3 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Nov 3, 2020
…acrum

Suggest library/std when running all stage 0 tests

r? `@Mark-Simulacrum`
cc `@ijackson`

For context, this came out of a discord conversation where `@ijackson` was running `test --stage 1` when they were only adding doc-tests to the standard library.
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 3, 2020
Rollup of 7 pull requests

Successful merges:

 - rust-lang#77950 (Add support for SHA256 source file hashing)
 - rust-lang#78624 (Sync rustc_codegen_cranelift)
 - rust-lang#78626 (Improve errors about #[deprecated] attribute)
 - rust-lang#78659 (Corrected suggestion for generic parameters in `function_item_references` lint)
 - rust-lang#78687 (Suggest library/std when running all stage 0 tests)
 - rust-lang#78699 (Show more error information in lldb_batchmode)
 - rust-lang#78709 (Fix panic in bootstrap for non-workspace path dependencies.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8a1f9e0 into rust-lang:master Nov 3, 2020
@rustbot rustbot added this to the 1.49.0 milestone Nov 3, 2020
@jyn514 jyn514 deleted the bootstrap-help branch November 3, 2020 21:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust C-enhancement Category: An issue proposing an enhancement or a PR with one. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants