Skip to content

Add a test for r# identifiers #78962

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 15, 2020
Merged

Add a test for r# identifiers #78962

merged 4 commits into from
Nov 15, 2020

Conversation

poliorcetics
Copy link
Contributor

I'm not entirely sure I properly ran the test locally (I think so though), waiting for CI to confirm. :)

@rustbot modify labels: T-rustdoc

r? @jyn514

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Nov 12, 2020
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 12, 2020
jyn514
jyn514 reviewed Nov 12, 2020
View reviewed changes
@poliorcetics
Use intradoc-links for the whole test, add a @Has check
ecfeac5 
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
@jyn514
Copy link
Member

jyn514 commented Nov 12, 2020 •
edited
Loading 

 11: @has check failed
	`XPATH PATTERN` did not match
	    // @has 'raw_ident_eliminate_r_hashtag/internal/struct.B.html' '//a[@href="../raw_ident_eliminate_r_hashtag/internal/struct.mod.html"]' 'name'
12: @has check failed
	`XPATH PATTERN` did not match
	    // @has 'raw_ident_eliminate_r_hashtag/internal/struct.B.html' '//a[@href="../raw_ident_eliminate_r_hashtag/internal/struct.mod.html"]' 'other name'
19: @has check failed
	File does not exist 'raw_ident_eliminate_r_hashtag/struct.A.html'
	// @has 'raw_ident_eliminate_r_hashtag/struct.A.html' '//a[@href="../raw_ident_eliminate_r_hashtag/internal/struct.mod.html"]' 'name'

Looks like maybe this doesn't behave as expected?

@jyn514 jyn514 added A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2020
@poliorcetics
Copy link
Contributor Author

I think the XPATH is wrong, I will try something else based on existing tests in the other files.

@jyn514
Copy link
Member

jyn514 commented Nov 13, 2020

@bors r+ rollup

Thanks for the test!

@bors
Copy link
Collaborator

bors commented Nov 13, 2020

📌 Commit 309d863 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 13, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Nov 13, 2020
@Dylan-DPC
Rollup merge of rust-lang#78962 - poliorcetics:rustdoc-raw-ident-test…
578cc17 
…, r=jyn514

Add a test for r# identifiers

I'm not entirely sure I properly ran the test locally (I think so though), waiting for CI to confirm. :)

`@rustbot` modify labels: T-rustdoc

r? `@jyn514`
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Nov 13, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Nov 13, 2020
@Dylan-DPC
Rollup merge of rust-lang#78962 - poliorcetics:rustdoc-raw-ident-test…
6c58f45 
…, r=jyn514

Add a test for r# identifiers

I'm not entirely sure I properly ran the test locally (I think so though), waiting for CI to confirm. :)

``@rustbot`` modify labels: T-rustdoc

r? ``@jyn514``
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Nov 13, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Nov 14, 2020
@Dylan-DPC
Rollup merge of rust-lang#78962 - poliorcetics:rustdoc-raw-ident-test…
dd9485e 
…, r=jyn514

Add a test for r# identifiers

I'm not entirely sure I properly ran the test locally (I think so though), waiting for CI to confirm. :)

```@rustbot``` modify labels: T-rustdoc

r? ```@jyn514```
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Nov 14, 2020
Closed
@jonas-schievink jonas-schievink mentioned this pull request Nov 14, 2020
Closed
@jonas-schievink jonas-schievink mentioned this pull request Nov 14, 2020
Closed
@jonas-schievink jonas-schievink mentioned this pull request Nov 14, 2020
Closed
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Nov 15, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 15, 2020
@bors
Auto merge of rust-lang#79065 - Dylan-DPC:rollup-gag1drk, r=Dylan-DPC
7504256 
Rollup of 15 pull requests

Successful merges:

 - rust-lang#78352 (Do not call `unwrap` with `signatures` option enabled)
 - rust-lang#78590 (refactor: removing alloc::collections::vec_deque ignore-tidy-filelength)
 - rust-lang#78848 (Bump minimal supported LLVM version to 9)
 - rust-lang#78856 (Explicitly checking for or-pattern before test)
 - rust-lang#78948 (test: add `()=()=()=...` to weird-exprs.rs)
 - rust-lang#78962 (Add a test for r# identifiers)
 - rust-lang#78963 (Added some unit tests as requested)
 - rust-lang#78966 (Never inline C variadics, cold functions, functions with incompatible attributes ...)
 - rust-lang#78968 (Include llvm-as in llvm-tools-preview component)
 - rust-lang#78969 (Normalize function type during validation)
 - rust-lang#78980 (Fix rustc_ast_pretty print_qpath resulting in invalid macro input)
 - rust-lang#78986 (Avoid installing external LLVM dylibs)
 - rust-lang#78988 (Fix an intrinsic invocation on threaded wasm)
 - rust-lang#78993 (rustc_target: Fix dash vs underscore mismatches in option names)
 - rust-lang#79013 (Clean up outdated `use_once_payload` pretty printer comment)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5060389 into rust-lang:master Nov 15, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 15, 2020
@poliorcetics poliorcetics deleted the rustdoc-raw-ident-test branch November 15, 2020 10:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees

@jyn514 jyn514

Labels
A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
5 participants
@poliorcetics @jyn514 @bors @rust-highfive @rustbot