[beta] limit chunk size for copy_file_range to 1GB per iteration #79007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will hopefully avoid EOVERFLOW errors on mipsel-unknown-linux-gnu But the error will remain unhandled if it still occurs. Proper handling is left to a future change.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive
added
the
S-waiting-on-review
This was referenced Nov 12, 2020
|
Going to close in favor of #79008, which I have now r+'d. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 15, 2020
[beta] always disable copy_file_range to avoid EOVERFLOW errors A bigger hammer as alternative to rust-lang#79007 Pro: will certainly fix the issue Cons: will disable copy_file_range for everyone Resolves rust-lang#78979
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will hopefully avoid EOVERFLOW errors on mipsel-unknown-linux-gnu
But the error will remain unhandled if it still occurs. Proper handling is left to a future change.
I'm not entirely sure if it'll fix the issue, for a certain alternative see #79008
Resolves #78979