Update Clippy #79228
Merged
Update Clippy #79228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove a 'ERROR' comment from `borrow` `Vec<AtomicUsize>` itself is `Freeze` as it holds the atomic in heap * remove `ONCE_INIT` from `declare` it seems like an artifact from previous spliting
fix a false positive in two `interior_mutable_const` lints where a constant with enums gets linted even if it uses a clearly unfrozen variant. Note that the code uses the MIR interpreter, which the author of rust-lang#3962 thought unlikely to be a solution. This might be over-engineering; but, I think it's important to be able to work with the 'http' crate (rust-lang#3825).
Format lint categories as a table with the default lint level.
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
…in_manual_async, r=Manishearth Fix suggestion to add unneeded space in `manual_async` Fix a same case as rust-lang/rust-clippy#6247 changelog: Fix suggestion to add unneeded space in `manual_async`
…r=llogiq Fix unnecessary_lazy_eval suggestion applicability changelog: Fix unnecessary_lazy_eval suggestion applicability when breaking type inference Fixes rust-lang#6240
…=llogiq "Respect" enums in `interior_mutable_const` fixes rust-lang#3962 fixes rust-lang#3825 Hello, It might not be a good idea to submit another relatively large PR while I have an opened PR; but, I've finished this anyway. This may be able to wait for months. Note: the code uses the MIR interpreter, which the author of rust-lang#3962 thought unlikely to be a solution. This might be over-engineering; but, I think it's important to be able to work with the 'http' crate (rust-lang#3825). (And, I don't want to write a MIR visitor) --- changelog: fix a false positive in two `interior_mutable_const` lints where a constant with enums gets linted even if it uses a clearly unfrozen variant
Check when `from_utf8` is called from sliced byte array from string --- *Please keep the line below* changelog: Fix rust-lang#5487: Add linter to check when `from_utf8` is called from sliced byte array from string.
Readme improvements ~Moved the table of contents up, added an Overview heading.~ ~Made the "All the Clippy Lints" link clearer.~ Formatted the lint categories as a table with the default lint level (instead of saying on/off by default). Tweaked the descriptions. changelog: Improve Readme
Fix `await_holding_refcell_ref` examples for clarify - Remove redundant `()` - Fix variable name changelog: none
FROM_ITER_INSTEAD_OF_COLLECT: avoid unwrapping unconditionally Fixes rust-lang#6302 changelog: fix unwrap of None when checking libcore with clippy
do not trigger map_clone in the case of &mut fixes rust-lang#6299 changelog: do not trigger map_clone in the case of &mut
a typo typo changelog: none
Co-authored-by: oliver <16816606+o752d@users.noreply.github.com>
Small grammar, punctuation, and code style improvements to docs changelog: Made small grammar, punctuation, and code style improvements to docs I recently found some places in rust-lang/rust that had lists without spaces after commas, which led me to look for more places, which led me over here to find: - Some similar lists in code examples that could use spaces after commas to be idiomatic Rust style - Some lists in documentation text that didn't have spaces after commas, needed an Oxford comma (fight me), or were otherwise misformatted - Some other grammar improvements in the area of the other changes These changes should only be in user-facing documentation or output.
flip1995
force-pushed
the
clippyup
branch
3 times, most recently
from
2879f50 to
cd12d9c
Compare
This only happend when debug_assertions were enabled in rustc
|
@Manishearth 99b9459 fixed the ICE, but I'm not sure if the fix is correct. This ICE occurred, because of this debug assertion: rust/compiler/rustc_middle/src/ty/mod.rs Line 1455 in c643dd2 |
|
@bors r+ I'm trying to understand the issue, but the fix is conservative enough to definitely not make any problems, so let's merge this |
|
📌 Commit 99b9459 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Nov 24, 2020
Update Clippy Biweekly Clippy update r? `@Manishearth`
|
☀️ Test successful - checks-actions |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 6, 2020
Update Clippy Biweekly Clippy update r? `@Manishearth`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biweekly Clippy update
r? @Manishearth