Make fold_item_recur non-nullable
#79310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets rid of a bunch of `unwrap()`s and makes it a little more clear what's going on. Originally I wanted to make `fold_item` non-nullable too, which would have been a lot nicer to work with, but unfortunately `stripper` does actually return `None` in some places. I might make a follow-up moving stripper to be special and not a pass so that passes can be non-nullable.
jyn514
added
C-cleanup
This comment has been minimized.
This comment has been minimized.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Nov 23, 2020
|
Thanks! @bors: r+ |
|
📌 Commit ab1e634 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Nov 24, 2020
…meGomez Make `fold_item_recur` non-nullable This gets rid of a bunch of `unwrap()`s and makes it a little more clear what's going on. Originally I wanted to make `fold_item` non-nullable too, which would have been a lot nicer to work with, but unfortunately `stripper` does actually return `None` in some places. I might make a follow-up moving stripper to be special and not a pass so that passes can be non-nullable. Found while working on rust-lang#76998.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 24, 2020
…as-schievink Rollup of 10 pull requests Successful merges: - rust-lang#76858 (Add exploit mitigations chapter to the rustc book) - rust-lang#79310 (Make `fold_item_recur` non-nullable) - rust-lang#79312 (Get rid of `doctree::Impl`) - rust-lang#79321 (Accept '!' in intra-doc links) - rust-lang#79346 (Allow using `-Z fewer-names=no` to retain value names) - rust-lang#79351 (Fix typo in `keyword` docs for traits) - rust-lang#79354 (BTreeMap: cut out the ceremony around BoxedNode) - rust-lang#79358 (BTreeMap/BTreeSet: make public doc more consistent) - rust-lang#79367 (Allow disabling TrapUnreachable via -Ztrap-unreachable=no) - rust-lang#79374 (Add note to use nightly when using expr in const generics) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of a bunch of
unwrap()s and makes it a little more clearwhat's going on.
Originally I wanted to make
fold_itemnon-nullable too, which wouldhave been a lot nicer to work with, but unfortunately
stripperdoesactually return
Nonein some places. I might make a follow-up movingstripper to be special and not a pass so that passes can be
non-nullable.
Found while working on #76998.