Get rid of doctree::{ExternalCrate, ForeignItem, Trait, Function} #79335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
C-cleanup
rust-highfive
added
the
S-waiting-on-review
This was referenced Nov 23, 2020
GuillaumeGomez
approved these changes
Nov 24, 2020
|
The changes are great. We're finally getting rid of an intermediate step and I'm really glad you took time to do it. So whenever it's possible, r=me. |
|
@bors r=GuillaumeGomez rollup=never I want to be able to bisect. |
|
📌 Commit 3eac84a3914b6b60eac4d7b8ee1fabe9c4940762 has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-author
jyn514
force-pushed
the
doctree-crate
branch
from
3eac84a to
66e30ec
Compare
|
Apparently github and bors aren't smart enough to deal with commits that are in two different PRs? @bors r=GuillaumeGomez rollup=never |
|
📌 Commit 66e30ec has been approved by |
bors
added
S-waiting-on-bors
jyn514
changed the title
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 27, 2020
Cleanup more of rustdoc - Use `Item::from_def_id` for StructField - Use `from_def_id_and_parts` for primitives and keywords - Take `String` instead of `Symbol` in `from_def_id` - this avoids having to intern then immediately stringify the existing string. - Remove unused `get_stability` and `get_deprecation` - Remove unused `attrs` field from `primitives` - Remove unused `attrs` field from `keywords` This will probably conflict with rust-lang#79335 and I would prefer for that PR to land first - I'm anxious for rust-lang#77467 to land :) Makes rust-lang#76998 easier to add. r? `@GuillaumeGomez`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #79314, closes #79331, closes #79332. Follow-up to #79264 and #79312, continues breaking up #78082.
r? @GuillaumeGomez