Skip to content

Revert "Enable AVX512 *epi64 variants by updating stdarch" #79391

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed

Conversation

Mark-Simulacrum
Copy link
Member

This reverts commit d701bf9.

Tests whether this was responsible for regression in #79167.

r? @Mark-Simulacrum

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 24, 2020
@Mark-Simulacrum
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Collaborator

bors commented Nov 24, 2020

⌛ Trying commit e528f61 with merge 490cd5934a606d79cc82c5d16e4d71e0d9aa6dd5...

@m-ou-se m-ou-se added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2020
@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. labels Nov 24, 2020
@bors
Copy link
Collaborator

bors commented Nov 24, 2020

☀️ Try build successful - checks-actions
Build commit: 490cd5934a606d79cc82c5d16e4d71e0d9aa6dd5 (490cd5934a606d79cc82c5d16e4d71e0d9aa6dd5)

@rust-timer
Copy link
Collaborator

Queued 490cd5934a606d79cc82c5d16e4d71e0d9aa6dd5 with parent 7445993, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (490cd5934a606d79cc82c5d16e4d71e0d9aa6dd5): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot modify labels: +S-waiting-on-review -S-waiting-on-perf

@Mark-Simulacrum Mark-Simulacrum deleted the revert-avx512 branch November 25, 2020 02:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants