Skip to content

Change comments on types to doc-comments #79474

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2020
Merged

Change comments on types to doc-comments #79474

merged 1 commit into from
Nov 28, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Nov 27, 2020

Found while investigating #79459.

r? @Aaron1011

@jyn514 jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-trait-system Area: Trait system T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) labels Nov 27, 2020
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 27, 2020
@Aaron1011
Copy link
Member

@bors r+ rollup=always

@bors
Copy link
Collaborator

bors commented Nov 27, 2020

📌 Commit 2d39c09 has been approved by Aaron1011

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2020
@jonas-schievink jonas-schievink mentioned this pull request Nov 28, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 28, 2020
@bors
Auto merge of rust-lang#79507 - jonas-schievink:rollup-e5yeayh, r=jon…
e37f25a 
…as-schievink

Rollup of 10 pull requests

Successful merges:

 - rust-lang#78086 (Improve doc for 'as _')
 - rust-lang#78853 (rustc_parse: fix ConstBlock expr span)
 - rust-lang#79234 (Resolve typedefs in HashMap gdb/lldb pretty-printers)
 - rust-lang#79344 (Convert UNC path to local path to satisfy install script on Windows)
 - rust-lang#79383 (Fix bold code formatting in keyword docs)
 - rust-lang#79460 (Remove intermediate vectors from `add_bounds`)
 - rust-lang#79474 (Change comments on types to doc-comments)
 - rust-lang#79476 (Sync rustc_codegen_cranelift)
 - rust-lang#79478 (Expand docs on Peekable::peek_mut)
 - rust-lang#79486 (Slightly improve code samples in E0591)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit afc5542 into rust-lang:master Nov 28, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 28, 2020
@jyn514 jyn514 deleted the query-mode branch November 28, 2020 17:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Aaron1011 Aaron1011

Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-trait-system Area: Trait system C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jyn514 @Aaron1011 @bors @rust-highfive @rustbot