Skip to content

Add a doctest example of str::split on a slice of chars #79641

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2020
Merged

Add a doctest example of str::split on a slice of chars #79641

merged 1 commit into from
Dec 7, 2020

Conversation

sourcefrog
Copy link
Contributor

This is mentioned as supported, but the semantics are not described.

@sourcefrog
Add a doctest example of str::split on a slice of chars
0273f6f 
This is mentioned as supported, but the semantics are not described.
@rust-highfive
Copy link
Contributor

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 2, 2020
dtolnay
dtolnay approved these changes Dec 5, 2020
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented Dec 5, 2020

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 5, 2020

📌 Commit 0273f6f has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 5, 2020
@bors
Copy link
Collaborator

bors commented Dec 6, 2020

⌛ Testing commit 0273f6f with merge fd898519da216710cc519371b09ea03fffefb7fa...

@bors
Copy link
Collaborator

bors commented Dec 6, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 6, 2020
@sourcefrog
Copy link
Contributor Author

It looks like the build failure is due to irrelevant flakiness on auto (x86_64-apple, ./x.py --stage 2 test, --build=x86_64-apple-darwin --enable-sanitizers --enab... failing to install awscli.

@sourcefrog
Copy link
Contributor Author

@bors retry

@bors
Copy link
Collaborator

bors commented Dec 7, 2020

@sourcefrog: 🔑 Insufficient privileges: not in try users

@dtolnay
Copy link
Member

dtolnay commented Dec 7, 2020

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 7, 2020
@bors
Copy link
Collaborator

bors commented Dec 7, 2020

⌛ Testing commit 0273f6f with merge e5721a5...

@bors
Copy link
Collaborator

bors commented Dec 7, 2020

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing e5721a5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 7, 2020
@bors bors merged commit e5721a5 into rust-lang:master Dec 7, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 7, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sourcefrog @rust-highfive @dtolnay @bors @rustbot