Skip to content

move interpret::MemoryKind::Heap to const eval #79664

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

vn-ki
Copy link
Contributor

@vn-ki vn-ki commented Dec 3, 2020

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 3, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Dec 3, 2020

lgtm, just one small nit

@vn-ki vn-ki force-pushed the move-memkind-heap branch from 694c7d7 to 5b4fc6a Compare December 3, 2020 16:11
@vn-ki vn-ki force-pushed the move-memkind-heap branch from 5b4fc6a to ff0ebd2 Compare December 3, 2020 16:12
@oli-obk
Copy link
Contributor

oli-obk commented Dec 3, 2020

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 3, 2020

📌 Commit ff0ebd2 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2020
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 3, 2020
move interpret::MemoryKind::Heap to const eval

r? `@oli-obk`
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 4, 2020
Rollup of 11 pull requests

Successful merges:

 - rust-lang#77686 (Render Markdown in search results)
 - rust-lang#79541 (Doc keyword lint pass)
 - rust-lang#79602 (Fix SGX CI)
 - rust-lang#79611 (Use more std:: instead of core:: in docs for consistency)
 - rust-lang#79623 (Pass around Symbols instead of Idents in doctree)
 - rust-lang#79627 (Update cargo)
 - rust-lang#79631 (disable a ptr equality test on Miri)
 - rust-lang#79638 (Use `item_name` instead of pretty printing for resolving `Self` on intra-doc links)
 - rust-lang#79646 (rustc_metadata: Remove some dead code)
 - rust-lang#79664 (move interpret::MemoryKind::Heap to const eval)
 - rust-lang#79678 (Fix some clippy lints)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a2aa3d6 into rust-lang:master Dec 4, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 4, 2020
@oli-obk oli-obk mentioned this pull request Dec 20, 2020
3 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants