Change concurrency primitives to standard naming conventions #7978
Conversation
|
Apart from my minor nits, this looks great. Thanks for doing this. |
|
@bblum Actually, this doesn't really matter to me. Also, the helper functions don't show up in the documentation. |
|
also please @bblum me on arc-related pull requests? |
|
Oh, didn't realize c_void was already an empty enum. In that case, then, c_void is definitely the right thing to use for FFI-C-pointer types. |
|
@bblum: if they're opaque pointer types they should be their own uninhabited enum declarations, to avoid needlessly using weak typing |
|
@bblum You're right I should have added a CC @bblum to the summary of the pull request. I'll remember to do so in the future when working on arc related stuff. @thestinger I agree but that can wait until another pull request. I plan on doing some more work on this stuff. Also, isn't the runtime being rewritten in Rust anyways (or is this specific part going to still be in C++?) |
|
Had to rebase this because of 6174f9a . |
|
@thestinger Not sure why weak typing is bad. |
|
Can I get an r+, or criticism on why one should not be forthcoming? I don't want this pull request to just sit here, and bitrot. |
|
Criticism: I didn't know you had rebased again and needed another one. Apparently github does not send emails about such things. |
|
Yeah, there seem to be a lot of problems with rebasing, and GitHub. I'll just add another commit next time. |
|
I'd prefer to leave a comment; I don't like adding unnecessary extra commits, myself. |
|
Okay. I squashed it into the previous commit. |
|
Can't merge... |
To be more specific: `UPPERCASETYPE` was changed to `UppercaseType` `type_new` was changed to `Type::new` `type_function(value)` was changed to `value.method()`
|
Rebased. |
To be more specific: `UPPERCASETYPE` was changed to `UppercaseType` `type_new` was changed to `Type::new` `type_function(value)` was changed to `value.method()`
Add `unnecessary_to_owned` lint
This PR adds a lint to check for unnecessary calls to `ToOwned::to_owned` and other similar functions (e.g., `Cow::into_owned`, `ToString::to_string`, etc.).
The lint checks for expressions of the form `&receiver.to_owned_like()` used in a position requiring type `&T` where one of the following is true:
* `receiver`'s type is `T` exactly
* `receiver`'s type implements `Deref<Target = T>`
* `receiver`'s type implements `AsRef<T>`
The lint additionally checks for expressions of the form `receiver.to_owned_like()` used as arguments of type `impl AsRef<T>`.
It would be nice if the lint could also check for expressions used as arguments to functions like the following:
```
fn foo<T: AsRef<str>>(x: T) { ... }
```
However, I couldn't figure out how to determine whether a function input type was instantiated from a parameter with a trait bound.
If someone could offer me some guidance, I would be happy to add such functionality.
Closes rust-lang#7933
changelog: Add [`unnecessary_to_owned`] lint
To be more specific:
UPPERCASETYPEwas changed toUppercaseTypetype_newwas changed toType::newtype_function(value)was changed tovalue.method()