Use more symbols in rustdoc #80047
Use more symbols in rustdoc #80047
Conversation
jyn514
added
C-cleanup
`crate.name` is already set by `tcx.crate_name`, there's no need to override it.
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. |
|
⌛ Trying commit 7ee8e18 with merge af8283101a3e4aa82fbf6b6a660fe105a85c9297... |
|
☀️ Try build successful - checks-actions |
|
Queued af8283101a3e4aa82fbf6b6a660fe105a85c9297 with parent 4031f7b, future comparison URL. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
jyn514
removed
the
S-blocked
|
Finished benchmarking try commit (af8283101a3e4aa82fbf6b6a660fe105a85c9297): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
rustbot
added
S-waiting-on-review
|
Both instruction counts and max-rss look like noise. @GuillaumeGomez said he was working on converting even more strings to symbols, maybe that will combine well? I don't feel super strongly about whether this lands. |
Replace String with Symbol where possible The same as rust-lang#80047 but on different types. Might be interesting to run some perf comparison. r? `@jyn514`
|
Let's get this in as well! Thanks! @bors: r+ rollup |
|
📌 Commit 7ee8e18 has been approved by |
bors
added
S-waiting-on-bors
…laumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#80006 (BTreeMap: more expressive local variables in merge) - rust-lang#80022 (BTreeSet: simplify implementation of pop_first/pop_last) - rust-lang#80035 (Optimization for bool's PartialOrd impl) - rust-lang#80040 (Always run intrinsics lowering pass) - rust-lang#80047 (Use more symbols in rustdoc) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
@GuillaumeGomez anything that affects perf should not be rolled up, it means you can't find which PRs had an impact and it mask regressions. |
|
Arf indeed... The |
|
It's ok, fortunately this one didn't have much of an impact. |
Builds on #80044 and should not be merged before.
I want to test if this is actually faster before merging it, there was a lot of
to_string()calls so I'm not sure it will actually help. That means I have to wait for 80044 to get merged before running perf.r? @ghost