Skip to content

Revert change to trait evaluation order #80132

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 19, 2020

Conversation

matthewjasper
Copy link
Contributor

This change breaks some code and doesn't appear to enable any new code.

closes #79902

r? @nikomatsakis

This change breaks some code and doesn't appear to enable any new code.
@matthewjasper matthewjasper added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 17, 2020
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 17, 2020
@matthewjasper matthewjasper changed the title Revert change to evaluation order Revert change to trait evaluation order Dec 18, 2020
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 19, 2020

📌 Commit 3e31ffd has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 19, 2020
@bors
Copy link
Collaborator

bors commented Dec 19, 2020

⌛ Testing commit 3e31ffd with merge 1b6b06a...

@bors
Copy link
Collaborator

bors commented Dec 19, 2020

☀️ Test successful - checks-actions
Approved by: nikomatsakis
Pushing 1b6b06a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 19, 2020
@bors bors merged commit 1b6b06a into rust-lang:master Dec 19, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 19, 2020
@matthewjasper matthewjasper deleted the revert-eval-order branch December 20, 2020 18:39
@Mark-Simulacrum Mark-Simulacrum added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Dec 25, 2020
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 27, 2020
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.50.0, 1.49.0 Dec 27, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 28, 2020
…ulacrum

[beta] backports

This backports the following to 1.49:

*  Revert change to trait evaluation order rust-lang#80132
*  Don't allow `const` to begin a nonterminal rust-lang#80135
*  Prevent caching normalization results with a cycle rust-lang#80246

r? `@Mark-Simulacrum`
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regression 1.49: unexpected unsized tail ICE
6 participants