Skip to content

rustpkg: Handle non-numeric versions; some cleanup #8032

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 4 commits into from

Conversation

catamorphism
Copy link
Contributor

r? @graydon Package IDs can now be of the form a/b/c#FOO, where (if a/b/c is
a git repository) FOO is any tag in the repository. Non-numeric
tags only match against package IDs with the same tag, and aren't
compared linearly like numeric versions.

While I was at it, refactored the code that calls git clone, and segregated build output properly for different packages.

Package IDs can now be of the form a/b/c#FOO, where (if a/b/c is
a git repository) FOO is any tag in the repository. Non-numeric
tags only match against package IDs with the same tag, and aren't
compared linearly like numeric versions.

While I was at it, refactored the code that calls `git clone`,
and segregated build output properly for different packages.
@emberian
Copy link
Member

"Oh. Yeah, it should probably not force the tag interpretation as that won't work for other opaque refspecs (eg. revids)" (graydon in #6411)

@graydon
Copy link
Contributor

graydon commented Jul 26, 2013

@catamorphism all I mean by that is that if you can make it work without formatting the refspec as "tag/%s" I think it should be happy with tags, branches, revids and other things there. Git (and many VCSs) are willing to do best-effort parsing on references like this. See https://www.kernel.org/pub/software/scm/git/docs/git-rev-parse.html for example. I think you don't need to be specific.

Just pass it directly to git, without prefixing it with tags/
@catamorphism
Copy link
Contributor Author

r? @graydon again

@catamorphism
Copy link
Contributor Author

r? @graydon one more time for the documentation.

bors added a commit that referenced this pull request Jul 29, 2013
r? @graydon    Package IDs can now be of the form a/b/c#FOO, where (if a/b/c is
    a git repository) FOO is any tag in the repository. Non-numeric
    tags only match against package IDs with the same tag, and aren't
    compared linearly like numeric versions.
    
 While I was at it, refactored the code that calls `git clone`,  and segregated build output properly for different packages.
@bors bors closed this Jul 29, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Dec 2, 2021
Use new template forms for issue templates

GitHub has a new way to define issue templates. This gives an even more consistent formatting of our issues.

You can find (read-only) rendered versions [here](https://github.com/flip1995/rust-clippy/tree/new_templates/.github/ISSUE_TEMPLATE). If you want to try to fill out this kind of issue, you can do this in the [`cargo` Repo](https://github.com/rust-lang/cargo/issues/new/choose).

changelog: Better issue templates
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants