-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Edit rustc_middle::dep_graph module documentation #80325
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
r? @cjgillot |
You may also want to edit the docs for |
@@ -28,8 +30,12 @@ | |||
//! could not be instantiated because the current compilation session | |||
//! contained no `DefId` for thing that had been removed. | |||
//! | |||
//! ## `DepNode` creation and "inference" | |||
//! | |||
// Where is the `define_dep_nodes!()` macro? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The define_dep_nodes macro is defined in dep_node.rs.
It defines the DepKind
enum, and DepConstructor
.
DepNode
is defined in rustc_query_system::dep_graph::dep_node.
//! `DepNode` definition happens in the `define_dep_nodes!()` macro. This macro | ||
//! defines the `DepKind` enum and a corresponding `DepConstructor` enum. The | ||
//! defines the `DepKind` enum and a corresponding [`DepConstructor`] enum. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive-by: DepConstructor should really just be a mod
, since all it does is provide a namespace for functions constructing DepNode
s.
@@ -50,6 +56,12 @@ | |||
//! than a zeroed out fingerprint. More generally speaking, it relieves the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure the API is that restricted any more. There is an escape hatch DepNode::new_no_params
which is used in non-incremental runs.
Maybe that module should link to |
☔ The latest upstream changes (presumably #78452) made this pull request unmergeable. Please resolve the merge conflicts. |
…erister Get rid of `DepConstructor` This removes fully 235 unused functions. Follow-up to rust-lang#80325 (comment). r? `@michaelwoerister` cc `@cjgillot`
…erister Get rid of `DepConstructor` This removes fully 235 unused functions. Follow-up to rust-lang#80325 (comment). r? ``@michaelwoerister`` cc ``@cjgillot``
This fixes the module-level docs not rendering. (As of this writing, the module description is missing from https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/dep_graph/index.html).
The job Click to see the possible cause of the failure (guessed by this bot)
|
Not at all sure I did this rebase correctly... 🤔 |
☔ The latest upstream changes (presumably #81093) made this pull request unmergeable. Please resolve the merge conflicts. |
The first commit here moves the content to
mod.rs
, the second contains edits.The section I've called "DepNode creation and 'inference'" appears to have some outdated material. (
DepConstructor
is a struct, not an enum.)