Skip to content

Remove compile-fail test suite #80453

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2020
Merged

Remove compile-fail test suite #80453

merged 1 commit into from
Dec 30, 2020

Conversation

petrochenkov
Copy link
Contributor

By moving all of its tests to ui test suite.
Now we have directives like // dont-check-compiler-stderr that allow to disable .stderr comparison for platform-dependent tests without introducing a whole new test suite.

@rust-highfive
Copy link
Contributor

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 28, 2020
@rust-log-analyzer

This comment has been minimized.

# to view
@jyn514 jyn514 added A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Dec 28, 2020
@rust-log-analyzer

This comment has been minimized.

# to view
@lcnr
Copy link
Contributor

lcnr commented Dec 28, 2020

not familiar with the affected areas, maybe

r? @Mark-Simulacrum

@petrochenkov petrochenkov changed the title [WIP] Remove compile-fail test suite Remove compile-fail test suite Dec 28, 2020
@petrochenkov
Copy link
Contributor Author

PR CI (Linux) is green and I tested this locally on Windows, so this should be ready for the big CI.
It is still probably going to fail a couple of times on more exotic targets though.
@bors rollup=never

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented Dec 28, 2020

📌 Commit 69ddc42dd7a31c235c110d6ee198a226fb36009f has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2020
@bors
Copy link
Collaborator

bors commented Dec 29, 2020

⌛ Testing commit 69ddc42dd7a31c235c110d6ee198a226fb36009f with merge 89ae219167d7bfba851f3f4d4748648b28d3b67c...

@rust-log-analyzer

This comment has been minimized.

# to view
@bors

This comment has been minimized.

# to view
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 29, 2020
@petrochenkov
Copy link
Contributor Author

@bors r=Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Dec 29, 2020

📌 Commit eb322babd2adff35fefcb707a700f43bb77f0b9c has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2020
@rust-log-analyzer

This comment has been minimized.

# to view
@bors

This comment has been minimized.

# to view
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 29, 2020
@petrochenkov
Copy link
Contributor Author

@bors r=Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Dec 29, 2020

📌 Commit 2ad6e5394ce6ee9f11bbfdbb0c8a5173e6e8975c has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2020
@bors
Copy link
Collaborator

bors commented Dec 29, 2020

⌛ Testing commit 2ad6e5394ce6ee9f11bbfdbb0c8a5173e6e8975c with merge b5cc1c71e9d05137cac9c3ce6f32697346b49eae...

@rust-log-analyzer

This comment has been minimized.

# to view
@bors

This comment has been minimized.

# to view
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 29, 2020
@petrochenkov
Copy link
Contributor Author

@bors r=Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Dec 29, 2020

📌 Commit 4d2d0ba has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2020
@bors
Copy link
Collaborator

bors commented Dec 29, 2020

⌛ Testing commit 4d2d0ba with merge f3eead1...

@bors
Copy link
Collaborator

bors commented Dec 30, 2020

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing f3eead1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 30, 2020
@bors bors merged commit f3eead1 into rust-lang:master Dec 30, 2020
@rustbot rustbot added this to the 1.51.0 milestone Dec 30, 2020
@bors bors mentioned this pull request Dec 30, 2020
Closed
7 tasks
@wesleywiser wesleywiser mentioned this pull request Nov 5, 2021
Closed
@petrochenkov petrochenkov deleted the nocfail branch February 22, 2025 18:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.51.0
Development

Successfully merging this pull request may close these issues.
8 participants
@petrochenkov @rust-highfive @rust-log-analyzer @lcnr @Mark-Simulacrum @bors @jyn514 @rustbot