Stabilize by-value `[T; N]` iterator `core::array::IntoIter` #80470

SimonSapin · 2020-12-29T08:28:34Z

Tracking issue: #65798

This is unblocked now that min_const_generics has been stabilized in #79135.

This PR does not include the corresponding IntoIterator impl, which is #65819. Instead, an iterator can be constructed through the new method.

new would become unnecessary when IntoIterator is implemented and might be deprecated then, although it will stay stable.

Tracking issue: rust-lang#65798 This is unblocked now that `min_const_generics` has been stabilized in rust-lang#79135. This PR does *not* include the corresponding `IntoIterator` impl, which is rust-lang#65819. Instead, an iterator can be constructed through the `new` method. `new` would become unnecessary when `IntoIterator` is implemented and might be deprecated then, although it will stay stable.

rust-highfive · 2020-12-29T08:28:37Z

r? @cramertj

(rust-highfive has picked a reviewer for you, use r? to override)

SimonSapin · 2020-12-29T08:29:51Z

Stabilizing this iterator type with a new constructor that might be deprecated when IntoIterator is implemented later.

@rfcbot fcp merge

SimonSapin · 2020-12-30T08:13:49Z

Ah I forgot I need to be in the checkboxy list to propose FCP. @rust-lang/libs please start the process for:

Stabilizing this iterator type with a new constructor that might be deprecated when IntoIterator is implemented later.

m-ou-se · 2020-12-30T12:29:14Z

@rfcbot fcp merge

rfcbot · 2020-12-30T12:29:15Z

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2021-01-20T20:54:29Z

🔔 This is now entering its final comment period, as per the review above. 🔔

SoniEx2 · 2021-01-21T03:48:53Z

Instead of having ::new, why not propose From for all stdlib iterators?

library/core/src/array/iter.rs

Co-authored-by: Ashley Mannix <kodraus@hey.com>

SimonSapin · 2021-01-21T14:53:17Z

@SoniEx2 I’m not sure what impls you have in mind, could you spell them out?

SoniEx2 · 2021-01-21T15:07:37Z

Instead of having an IntoIter::new(...), have an IntoIter::from(...) powered by trait From.

This would be undeprecatable but it feels less silly and could be extended to the other iterators. Then you'd just use .into() and impl Iterator<Item=...>.

// example usage
BTreeMap::<&'static str, &'static str>::from_iter([("a", "b")].into())

SimonSapin · 2021-01-21T15:14:41Z

There’s no need to find another general pattern to turn collections into iterators, that’s the IntoIterator trait

SoniEx2 · 2021-01-21T15:25:51Z

alternatively: [("a", "b")].into(): impl Iterator<Item=(&'static str, &'static str)>.collect::<BTreeMap<_, _>>()

the point is you'd use IntoIter::from() / [T; N].into() instead of [T; N].into_iter().

rust-log-analyzer · 2021-01-21T15:29:35Z

The job x86_64-gnu-llvm-9 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Successfully built ef9d50b97d38
Successfully tagged rust-ci:latest
Built container sha256:ef9d50b97d388e6ba90f8388b0997d746b3b0aae438d65cbb1bfb909e713d215
Uploading finished image to https://ci-caches.rust-lang.org/docker/1d8776fc6611839c0fe1104032e04cb412cf84a696fcac0418b82e4341b3688a883196f99e2f55a0df0b3c67d154c62dd0c4630956d70292523c69687b63cce6
upload failed: - to s3://rust-lang-ci-sccache2/docker/1d8776fc6611839c0fe1104032e04cb412cf84a696fcac0418b82e4341b3688a883196f99e2f55a0df0b3c67d154c62dd0c4630956d70292523c69687b63cce6 Unable to locate credentials
[CI_JOB_NAME=x86_64-gnu-llvm-9]
---
Suite("src/test/assembly") not skipped for "bootstrap::test::Assembly" -- not in ["src/tools/tidy"]
Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)

running 29 tests
iiiiiiiiiiiiiiiiiiiiiiiiiiiii

 finished in 0.064 seconds
Suite("src/test/incremental") not skipped for "bootstrap::test::Incremental" -- not in ["src/tools/tidy"]
Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
Suite("src/test/debuginfo") not skipped for "bootstrap::test::Debuginfo" -- not in ["src/tools/tidy"]
Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)

running 116 tests
iiiiiiiiii.i.i..i...i.ii....i.i....ii..........iiii.........i.....i...i.......ii.i.ii.....iiii.....i 100/116
test result: ok. 78 passed; 0 failed; 38 ignored; 0 measured; 0 filtered out; finished in 2.01s

 finished in 2.085 seconds
Suite("src/test/ui-fulldeps") not skipped for "bootstrap::test::UiFullDeps" -- not in ["src/tools/tidy"]
---
Suite("src/test/run-make") not skipped for "bootstrap::test::RunMake" -- not in ["src/tools/tidy"]
Check compiletest suite=run-make mode=run-make (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)

running 20 tests
iiiiiiiiiiii........

 finished in 0.517 seconds
Build completed successfully in 0:29:22
+ python2.7 ../x.py --stage 2 test src/test/mir-opt --host= --target=i686-unknown-linux-gnu
---
Check compiletest suite=ui mode=ui (x86_64-unknown-linux-gnu -> i686-unknown-linux-gnu)

running 11271 tests
.....................i.............................................................................. 100/11271
.................................iiiiiiii.iiiiiiiii................................................. 200/11271
.................................................................................................... 400/11271
.................................................................................................... 500/11271
.................................................................................................... 600/11271
....................................................i............................................... 700/11271

rfcbot · 2021-01-30T20:59:41Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

m-ou-se · 2021-01-30T21:07:29Z

@bors r+ rollup

bors · 2021-01-30T21:07:30Z

📌 Commit 83d32b0 has been approved by m-ou-se

…as-schievink Rollup of 18 pull requests Successful merges: - rust-lang#78044 (Implement io::Seek for io::Empty) - rust-lang#79285 (Stabilize Arc::{increment,decrement}_strong_count) - rust-lang#80053 (stabilise `cargo test -- --include-ignored`) - rust-lang#80279 (Implement missing `AsMut<str>` for `str`) - rust-lang#80470 (Stabilize by-value `[T; N]` iterator `core::array::IntoIter`) - rust-lang#80945 (Add Box::downcast() for dyn Any + Send + Sync) - rust-lang#81048 (Stabilize `core::slice::fill_with`) - rust-lang#81198 (Remove requirement that forces symmetric and transitive PartialEq impls to exist) - rust-lang#81422 (Account for existing `_` field pattern when suggesting `..`) - rust-lang#81472 (Clone entire `TokenCursor` when collecting tokens) - rust-lang#81484 (Optimize decimal formatting of 128-bit integers) - rust-lang#81491 (Balance sidebar `Deref` cycle check with main content) - rust-lang#81509 (Add a regression test for ICE of bad_placeholder_type) - rust-lang#81547 (Edit rustc_typeck top-level docs) - rust-lang#81550 (Replace predecessor with range in collections documentation) - rust-lang#81558 (Fix ascii art text wrapping in mobile) - rust-lang#81562 (Clarify that InPlaceIterable guarantees extend to all advancing iterator methods.) - rust-lang#81563 (Improve docblock readability on small screen) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

SimonSapin added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. A-iterators Area: Iterators labels Dec 29, 2020

rust-highfive assigned cramertj Dec 29, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 29, 2020

SimonSapin mentioned this pull request Dec 29, 2020

Tracking issue for by-value array iterator (feature array_value_iter) #65798

Closed

3 tasks

jonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label Dec 29, 2020

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Dec 30, 2020

m-ou-se assigned m-ou-se and unassigned cramertj Dec 30, 2020

m-ou-se added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 30, 2020

LukasKalbertodt mentioned this pull request Dec 30, 2020

Add IntoIterator impl for arrays by value (for [T; N]) #65819

Closed

5 tasks

usbalbin mentioned this pull request Jan 2, 2021

Tracking Issue for array_zip #80094

Closed

2 tasks

rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Jan 20, 2021

rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Jan 20, 2021

KodrAus reviewed Jan 21, 2021

View reviewed changes

library/core/src/array/iter.rs Show resolved Hide resolved

Add example to array::IntoIter::new’s doc-comment

83d32b0

Co-authored-by: Ashley Mannix <kodraus@hey.com>

This comment has been minimized.

# to view

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 21, 2021

m-ou-se removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 21, 2021

rfcbot added the finished-final-comment-period The final comment period is finished for this PR / Issue. label Jan 30, 2021

rfcbot added to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jan 30, 2021

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 30, 2021

jonas-schievink mentioned this pull request Jan 31, 2021

Rollup of 18 pull requests #81578

Merged

bors merged commit 1e99f26 into rust-lang:master Jan 31, 2021

rustbot added this to the 1.51.0 milestone Jan 31, 2021

rkowalewski mentioned this pull request Feb 5, 2021

Cannot bootstrap rustfmt in-tree: unknown feature array_value_iter_slice #81787

Closed

apiraino removed the to-announce Announce this issue on triage meeting label Feb 11, 2021

lcnr mentioned this pull request Dec 11, 2021

Tracking issue for const generics (RFC 2000) #44580

Closed

16 tasks

Stabilize by-value [T; N] iterator core::array::IntoIter #80470

Stabilize by-value [T; N] iterator core::array::IntoIter #80470

Uh oh!

Conversation

SimonSapin commented Dec 29, 2020

Uh oh!

rust-highfive commented Dec 29, 2020

Uh oh!

SimonSapin commented Dec 29, 2020

Uh oh!

SimonSapin commented Dec 30, 2020

Uh oh!

m-ou-se commented Dec 30, 2020

Uh oh!

rfcbot commented Dec 30, 2020 • edited by KodrAus Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rfcbot commented Jan 20, 2021

Uh oh!

SoniEx2 commented Jan 21, 2021

Uh oh!

Uh oh!

SimonSapin commented Jan 21, 2021

Uh oh!

SoniEx2 commented Jan 21, 2021

Uh oh!

SimonSapin commented Jan 21, 2021

Uh oh!

SoniEx2 commented Jan 21, 2021

Uh oh!

rust-log-analyzer commented Jan 21, 2021

Uh oh!

This comment has been minimized.

rfcbot commented Jan 30, 2021

Uh oh!

m-ou-se commented Jan 30, 2021

Uh oh!

bors commented Jan 30, 2021

Uh oh!

Uh oh!

Stabilize by-value `[T; N]` iterator `core::array::IntoIter` #80470

Stabilize by-value `[T; N]` iterator `core::array::IntoIter` #80470

rfcbot commented Dec 30, 2020 •

edited by KodrAus

Loading