-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Choose an appropriate python version for x.py at runtime #80585
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
8e77d03
to
b60bf06
Compare
I found that this breaks on CentOS because it doesn't have |
- Default to python3 -> python -> python2 - Start as shell script and re-execute the program with the right python interpreter
b60bf06
to
47980db
Compare
This breaks in Powershell (probably cmd.exe too, but I don't know how to install that on linux):
|
It looks like servo handles this by having a separate |
Are you sure this isn't missing a shebang for shell of some sort? Running
|
@nagisa most shells will execute files as scripts if they don't have a shebang, what shell are you using? That said, if this doesn't work even on linux, it's probably not worth pursuing. |
I use |
…ulacrum Choose the version of python at runtime (portable version) r? `@Mark-Simulacrum` Fixed version of rust-lang#80585. The goal is to avoid giving 'error: python3 required' when downloading LLVM from CI and instead default to python3 where possible. This has some minor overhead when you have `python` as python2, but almost nothing compared to actually running the build.
Or, how I learned to stop worrying and love the shell.
x.py
as a shell script and re-execute the program with the right python interpreterCloses #71818.
r? @Mark-Simulacrum